[MacPorts] #59424: openssh @8.1p1_1: error: use of undeclared identifier 'kSecAttrAccessGroup'

[MacPorts]

#59424: openssh @8.1p1_1: error: use of undeclared identifier 'kSecAttrAccessGroup'
----------------------+----------------------
  Reporter:  iEFdev   |      Owner:  Ionic
      Type:  defect   |     Status:  reopened
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.6.2
Resolution:           |   Keywords:  lion
      Port:  openssh  |
----------------------+----------------------
Changes (by iEFdev):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Thanks! One step ahead. Now there are a few errors on type and method.

 {{{
 :info:build keychain.m:100:32: error: unexpected type name 'BOOL':
 expected expression
 :info:build                                (id)kSecReturnData: @YES};
 :info:build                                                     ^
 :info:build /usr/include/objc/objc.h:50:26: note: expanded from macro
 'YES'
 :info:build #define YES             (BOOL)1
 :info:build                          ^
 :info:build /usr/bin/clang -pipe -Os -fPIE -arch x86_64 -pipe -Wunknown-
 warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized
 -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-
 sign -Wno-unused-result -fno-strict-aliasing -mretpoline
 -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -fstack-protector-strong
 -fPIE   -I. -I. -I/opt/local/include -I/opt/local/include
 -I/opt/local/include -DBROKEN_STRNVIS=1 -D__APPLE_SANDBOX_NAMED_EXTERNAL__
 -D__APPLE_API_STRICT_CONFORMANCE -I/opt/local/include/editline
 -I/opt/local/include -I/opt/local/include -D__APPLE_KEYCHAIN__
 -D__APPLE_MEMBERSHIP__ -D__APPLE_TMPDIR__ -D__APPLE_LAUNCHD__
 -DSSHDIR=\"/opt/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/opt/local/bin/ssh\"
 -D_PATH_SSH_ASKPASS_DEFAULT=\"/opt/local/libexec/ssh-askpass\"
 -D_PATH_SFTP_SERVER=\"/opt/local/libexec/sftp-server\"
 -D_PATH_SSH_KEY_SIGN=\"/opt/local/libexec/ssh-keysign\"
 -D_PATH_SSH_PKCS11_HELPER=\"/opt/local/libexec/ssh-pkcs11-helper\"
 -D_PATH_SSH_PIDDIR=\"/opt/local/var/run\"
 -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c auth-shadow.c
 -o auth-shadow.o
 :info:build keychain.m:160:60: error: unexpected type name 'BOOL':
 expected expression
 :info:build         NSMutableDictionary *searchQuery =
 [@{(id)kSecReturnRef: @YES} mutableCopy];
 :info:build
 ^
 :info:build /usr/include/objc/objc.h:50:26: note: expanded from macro
 'YES'
 :info:build #define YES             (BOOL)1
 :info:build                          ^
 :info:build keychain.m:250:32: error: unexpected type name 'BOOL':
 expected expression
 :info:build                                 (id)kSecReturnAttributes:
 @YES,
 :info:build                                                            ^
 :info:build /usr/include/objc/objc.h:50:26: note: expanded from macro
 'YES'
 :info:build #define YES             (BOOL)1
 :info:build                          ^
 :info:build keychain.m:263:29: error: expected method to read dictionary
 element not found on object of type 'NSDictionary *'
 :info:build                 NSString        *accountString =
 itemAttributes[(id)kSecAttrAccount];
 :info:build                                                  ^
 :info:build 4 errors generated.
 }}}

 -----

 Turning the 3 `@YES` into `@"YES"`, and also stringify the
 `"itemAttributes[(id)kSecAttrAccount]"`…

 I don't know if that's correct, but it didn't return any new errors, and
 it finished the `port build openssh`. Tried `ssh-add --help` (in the work
 directory) and the keychain popped up and asked if it could use a new key
 I added yesterday. So the connection seems to be there.

-- 
Ticket URL: <https://trac.macports.org/ticket/59424#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS