[MacPorts] #59397: openssh @8.1_1: fails to build on 10.6: audit-bsm.c:66:10: fatal error: 'bsm/audit_session.h' file not found

[MacPorts]

#59397: openssh @8.1_1: fails to build on 10.6: audit-bsm.c:66:10: fatal error:
'bsm/audit_session.h' file not found
-------------------------+----------------------------------------
  Reporter:  grumpybozo  |      Owner:  Ionic
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.1
Resolution:  fixed       |   Keywords:  snowleopard lion legacy-os
      Port:  openssh     |
-------------------------+----------------------------------------

Comment (by Ionic):

 `CFString` is way old. The latter webpage lists 10.0(!) as the first
 supported version.

 Hmm, `kSecReturnAttributes` doesn't make sense... the (ObjC) documentation
 says "Boolean" and the discussion also mentions `CFBooleanRef`, but the
 prototype really lists `CFStringRef`. Oddly the code compiles fine on my
 10.9 machine, and the actual prototype in the header file says `const
 CFTypeRef`, which is an untyped version used as a placeholder. The
 bridgesupport file also lists its type as "@" which sounds like a
 `CFBooleanRef` to me...

 Then again, looking at the most recent version of
 [https://opensource.apple.com/source/Security/Security-58286.260.20/keychain/SecItem.h.auto.html
 SecItem.h] in the Security framework, they really did change the
 declaration to `CFStringRef` for whatever reason. I really don't get it.

 Since the code works on 10.8+, that's probably not an issue.

 Can you please try to change the `@YES` parts (for `kSecReturnAttributes`
 and `kSecReturnRef` only) to `@(YES)` and see if that compiles on 10.7?
 (Maybe it's just syntactic sugar that is missing here.)

 If it doesn't, replace that with `[NSNumber numberWithBool:YES]`. (`@YES`
 should be equivalent to this statement.)

 And if that also doesn't, let's try `[[NSNumber numberWithBool:YES]
 stringValue]`. (That's essentially `@YES` converted to an `NSString`.)

 I can't test this reasonably myself.

-- 
Ticket URL: <https://trac.macports.org/ticket/59397#comment:31>
MacPorts <https://www.macports.org/>
Ports system for macOS