[MacPorts] #58327: qcachegrind @0.7.4: error: ordered comparison between pointer and zero (was: qcachegrind-0.7.4_0: fails to compile libcore/tracedata.cpp)

[MacPorts]

#58327: qcachegrind @0.7.4: error: ordered comparison between pointer and zero
--------------------------+----------------------
  Reporter:  max-arnold   |      Owner:  devernay
      Type:  defect       |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:  2.5.4
Resolution:               |   Keywords:
      Port:  qcachegrind  |
--------------------------+----------------------
Changes (by ryandesign):

 * cc: iakoder, NicosPavlov (added)


Comment:

 Has duplicate #59526.

 I don't fully understand the relationship between "'''q'''cachegrind" and
 "'''k'''cachegrind" (we have ports for both) but looking at
 https://github.com/KDE/kcachegrind/blob/master/libcore/tracedata.cpp#L3264
 the developers don't seem to have fixed this problem. So the problem
 should be reported to them.

 The fix is probably simply:

 {{{
 --- tracedata.cpp.orig  2019-10-30 19:09:34.000000000 -0500
 +++ tracedata.cpp       2019-10-30 19:09:44.000000000 -0500
 @@ -3261,7 +3261,7 @@

  void TraceData::addPart(TracePart* part)
  {
 -    if (_parts.contains(part)>0) return;
 +    if (_parts.contains(part)) return;

      if ((part->partNumber()==0) &&
          (part->processID()==0)) {
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/58327#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS