[MacPorts] #59538: github portgroup doesn't work with default master_sites from other portgroups

[MacPorts]

#59538: github portgroup doesn't work with default master_sites from other
portgroups
--------------------+--------------------
 Reporter:  jmroot  |      Owner:  (none)
     Type:  defect  |     Status:  new
 Priority:  Normal  |  Milestone:
Component:  ports   |    Version:
 Keywords:          |       Port:
--------------------+--------------------
 The lack of renaming in #59525 seems to be because this check was false:
 https://github.com/macports/macports-
 ports/blob/master/_resources/port1.0/group/github-1.0.tcl#L92

 This is because the github portgroup only sets a default for master_sites;
 github.setup doesn't set it to a definite value. Is it intended that you
 should be able to use different master_sites after calling github.setup?
 If so, how is that supposed to behave? If not, I imagine github.setup
 should just set master_sites and the default is unnecessary.

-- 
Ticket URL: <https://trac.macports.org/ticket/59538>
MacPorts <https://www.macports.org/>
Ports system for macOS