[MacPorts] #56991: wine cannot be built against the 10.14 SDK

[MacPorts]

#56991: wine cannot be built against the 10.14 SDK
---------------------------------------------+------------------------
  Reporter:  IComplainInComments             |      Owner:  ryandesign
      Type:  defect                          |     Status:  assigned
  Priority:  Low                             |  Milestone:
 Component:  ports                           |    Version:  2.5.3
Resolution:                                  |   Keywords:  mojave
      Port:  wine wine-devel wine-crossover  |
---------------------------------------------+------------------------

Comment (by kencu):

 A very similar patch works to enable `+universal` building against an SDK
 with MacPorts 2.6, happily. There is just one little change in the quoting
 that appears to be needed for the new MacPorts:
 {{{
 $ diff -u
 /opt/universalnew/libexec/macports/lib/port1.0/portconfigure.tcl.orig
 /opt/universalnew/libexec/macports/lib/port1.0/portconfigure.tcl
 --- /opt/universalnew/libexec/macports/lib/port1.0/portconfigure.tcl.orig
 2019-09-21 16:25:24.000000000 -0700
 +++ /opt/universalnew/libexec/macports/lib/port1.0/portconfigure.tcl
 2019-09-21 16:26:20.000000000 -0700
 @@ -1477,6 +1477,8 @@
                  append_to_environment_value configure $env_var
 -isysroot${configure.sdkroot}
              }
              append_to_environment_value configure "LDFLAGS"
 -Wl,-syslibroot,${configure.sdkroot}
 +            append_to_environment_value configure "SDKROOT"
 ${configure.sdkroot}
 +            append_to_environment_value configure "LDFLAGS" -Wl,-w
          }

          # add extra flags that are conditional on whether we're building
 universal
 $ diff -u
 /opt/universalnew/libexec/macports/lib/port1.0/portbuild.tcl.orig
 /opt/universalnew/libexec/macports/lib/port1.0/portbuild.tcl
 --- /opt/universalnew/libexec/macports/lib/port1.0/portbuild.tcl.orig
 2019-09-21 16:27:06.000000000 -0700
 +++ /opt/universalnew/libexec/macports/lib/port1.0/portbuild.tcl
 2019-09-21 16:55:49.000000000 -0700
 @@ -197,6 +197,12 @@

      set jobs_suffix [build_getjobsarg]

 +    global configure.sdkroot
 +       if {${configure.sdkroot} ne ""} {
 +        ui_notice "setting build SDKROOT to ${configure.sdkroot}"
 +               build.env-append "SDKROOT=${configure.sdkroot}"
 +       }
 +
      set realcmd ${build.cmd}
      set build.cmd "${build.cmd}$jobs_suffix"
      command_exec build
 $ diff -u
 /opt/universalnew/libexec/macports/lib/port1.0/portdestroot.tcl.orig
 /opt/universalnew/libexec/macports/lib/port1.0/portdestroot.tcl
 --- /opt/universalnew/libexec/macports/lib/port1.0/portdestroot.tcl.orig
 2019-09-21 16:28:37.000000000 -0700
 +++ /opt/universalnew/libexec/macports/lib/port1.0/portdestroot.tcl
 2019-09-21 17:01:43.000000000 -0700
 @@ -121,6 +121,13 @@
  }

  proc portdestroot::destroot_main {args} {
 +
 +    global configure.sdkroot
 +       if {${configure.sdkroot} ne ""} {
 +        ui_notice "setting destroot SDKROOT to ${configure.sdkroot}"
 +               destroot.env-append "SDKROOT=${configure.sdkroot}"
 +       }
 +
      command_exec destroot
      return 0
  }
 }}}

 With that (and the added SDK and small changes in `macports.conf` and
 `variants.conf` as above) wine builds through from start to finish without
 touching a thing.

 If you might be so kind, I'd like to see your newer `wine-devel` version.
 Can you give us a link to your `Portfile`?

-- 
Ticket URL: <https://trac.macports.org/ticket/56991#comment:42>
MacPorts <https://www.macports.org/>
Ports system for macOS