[MacPorts] #56991: wine cannot be built against the 10.14 SDK

[MacPorts]

#56991: wine cannot be built against the 10.14 SDK
---------------------------------------------+------------------------
  Reporter:  IComplainInComments             |      Owner:  ryandesign
      Type:  defect                          |     Status:  assigned
  Priority:  Low                             |  Milestone:
 Component:  ports                           |    Version:  2.5.3
Resolution:                                  |   Keywords:  mojave
      Port:  wine wine-devel wine-crossover  |
---------------------------------------------+------------------------

Comment (by Gcenx):

 Replying to [comment:68 kencu]:
 > Replying to [comment:67 Gcenx]:
 > > @kencu you think is possible to replace the current  upstreamed patch
 with the version I provided?
 >
 > Probably. The port maintainer will look at what the benefit is, and how
 many systems might break unexpectedly. You'd be surprised at the
 unexpected wreckage we see all the time from patches that seem to work
 fine on several systems :>
 >
 > I would probably have to build it on every system to show him it works.
 >
 > And then there's be the question about the next version of libvpx, and
 will anything be different. So, although it seems pretty trivial, in the
 end there is always a certain amount of pushback for these reasons.

 I’m honestly asking because of what you explained, I stuck to the macports
 guidelines for Portfile’s with the patch changing the original files way
 of selecting the SDK to the macports recommenced way. Though I do see some
 gaps within the examples causing the ticket I opened for mingw-w64.

 I uploaded the remade .diff as a just incase it can’t be accepted for some
 reason it’s at least available, it’s easy enough to swap out the original
 patch with the one I uploaded.

-- 
Ticket URL: <https://trac.macports.org/ticket/56991#comment:69>
MacPorts <https://www.macports.org/>
Ports system for macOS