[MacPorts] #60296: acpica: ld: library not found for -lMacportsLegacySupport

[MacPorts]

#60296: acpica: ld: library not found for -lMacportsLegacySupport
-------------------------+---------------------------------
  Reporter:  ryandesign  |      Owner:  MarcusCalhoun-Lopez
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:  fixed       |   Keywords:
      Port:  acpica      |
-------------------------+---------------------------------

Comment (by kencu):

 Replying to [comment:5 MarcusCalhoun-Lopez]:
 > `legacysupport 1.0` modifies variables for **all** systems at or below
 10.11 before the rest of the Portfile is evaluated.\\
 > After the Portfile is evaluated, it tries to remove the modifications
 depending on the value of `legacysupport.newest_darwin_requires_legacy`.

 > `legacysupport 1.1` is less obtrusive.\\
 > It never modifies variables until it is sure the system requires the
 changes.

 Chris set it up this way, to make sure that the CFLAGS and LDFLAGS were
 set before the Portfile was first processed, so that ports that used those
 things would see proper values. And then removed them afterwards, after
 the portfile was processed, if {{{newest_darwin_requires_legacy}}}
 allowed.

 It seemed more bulletproof to do it that way with 20,000 ports, lots of
 them not using the standard autotools or cmake systems, and lots of
 shenanigans going on in various ports where the legacysupport PG might
 have unpredictable effects.

 It has worked OK but until now, but there may well be a better way to
 accomplish the same reliable outcome. I am not sure how else you could
 reliably do it, but I am not up-to-speed on the parsing behaviour of
 portfiles with respect to the setting of env vars, so I won't opine.

-- 
Ticket URL: <https://trac.macports.org/ticket/60296#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS