[MacPorts] #60366: liblas: Duplicate -DCMAKE_INSTALL_NAME_DIR=${prefix}/lib flag and reintroduction of rpath

[MacPorts]

#60366: liblas: Duplicate -DCMAKE_INSTALL_NAME_DIR=${prefix}/lib flag and
reintroduction of rpath
-------------------------+--------------------
  Reporter:  ryandesign  |      Owner:  (none)
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  liblas      |
-------------------------+--------------------

Comment (by mathstuf):

 > It seems pretty clear that it's the liblas CMakeLists.txt that's causing
 this to happen, with this block:

 Ah, I missed that. We should just patch that block. It's not a decision a
 project should be making (it's a deployment choice).

 > Per Mojca's comment in the PR, you had not initially increased the
 revision. Is it possible that when you reinstalled the port you received a
 binary of the existing version, rather than building your locally changed
 version?

 Unlikely; I had just manually patched the library at that point to test
 with the other code that was consuming it.

 Unfortunately, liblas is "dead" (PDAL is the replacement now). For
 example, liblas cannot read LAS file format 1.4; PDAL holds that code.
 Though looking now, some CVE patches did get in. I'll just submit a patch
 upstream and see what happens. We should probably grab the CVE patches
 anyways, so maybe a prod for a 1.8.2 could be made :) .

 > I agree, the difference in versioning between the symlink and the
 library was confusing, but it would not be the first time I've seen a
 project get their library versioning wildly wrong. I don't know at this
 point whether that wrongness came from the liblas project or from the
 portfile additions in this case.

 The reason I showed up was because the macports fix was incorrect :) . We
 can just patch the upstream project to not hard-code deployment decisions
 though.

-- 
Ticket URL: <https://trac.macports.org/ticket/60366#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS