[MacPorts] #61759: scale2x @2.4_2: implicit declared function strcmp

[MacPorts]

#61759: scale2x @2.4_2: implicit declared function strcmp
--------------------------+--------------------
  Reporter:  MaddTheSane  |      Owner:  (none)
      Type:  defect       |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:  2.6.4
Resolution:               |   Keywords:  bigsur
      Port:  scale2x      |
--------------------------+--------------------
Changes (by MaddTheSane):

 * keywords:   => bigsur


Old description:

> This is another case of a file not including the right header:
>

> {{{
> :info:build scalex.c:149:9: error: implicitly declaring library function
> 'strcmp' with type 'int (const char *, const char *)' [-Werror
> ,-Wimplicit-function-declaration]
> :info:build                                 if (strcmp(optarg, "2") == 0)
> {
> :info:build                                     ^
> :info:build scalex.c:149:9: note: include the header <string.h> or
> explicitly provide a declaration for 'strcmp'
> :info:build 1 error generated.
> :info:build make[1]: *** [scalex.o] Error 1
> :info:build make[1]: *** Waiting for unfinished jobs....
> :info:build scalerx.c:606:9: error: implicitly declaring library function
> 'strcmp' with type 'int (const char *, const char *)' [-Werror
> ,-Wimplicit-function-declaration]
> :info:build                                 if (strcmp(optarg, "2") == 0)
> {
> :info:build                                     ^
> :info:build scalerx.c:606:9: note: include the header <string.h> or
> explicitly provide a declaration for 'strcmp'
> :info:build 1 error generated.
> :info:build make[1]: *** [scalerx.o] Error 1
> }}}
>
> It looks like a simple patch will make it compile fine.

New description:

 This is another case of a file not including the right header introduced
 by Big Sur:


 {{{
 :info:build scalex.c:149:9: error: implicitly declaring library function
 'strcmp' with type 'int (const char *, const char *)' [-Werror,-Wimplicit-
 function-declaration]
 :info:build                                 if (strcmp(optarg, "2") == 0)
 {
 :info:build                                     ^
 :info:build scalex.c:149:9: note: include the header <string.h> or
 explicitly provide a declaration for 'strcmp'
 :info:build 1 error generated.
 :info:build make[1]: *** [scalex.o] Error 1
 :info:build make[1]: *** Waiting for unfinished jobs....
 :info:build scalerx.c:606:9: error: implicitly declaring library function
 'strcmp' with type 'int (const char *, const char *)' [-Werror,-Wimplicit-
 function-declaration]
 :info:build                                 if (strcmp(optarg, "2") == 0)
 {
 :info:build                                     ^
 :info:build scalerx.c:606:9: note: include the header <string.h> or
 explicitly provide a declaration for 'strcmp'
 :info:build 1 error generated.
 :info:build make[1]: *** [scalerx.o] Error 1
 }}}

 It looks like a simple patch will make it compile fine.

--

-- 
Ticket URL: <https://trac.macports.org/ticket/61759#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS