[MacPorts] #61019: mpbb: Remove failcache entry if port is already installed

[MacPorts]

#61019: mpbb: Remove failcache entry if port is already installed
----------------------------+------------------------
  Reporter:  ryandesign     |      Owner:  ryandesign
      Type:  enhancement    |     Status:  assigned
  Priority:  Normal         |  Milestone:
 Component:  buildbot/mpbb  |    Version:
Resolution:                 |   Keywords:  haspatch
      Port:                 |
----------------------------+------------------------
Description changed by ryandesign:

Old description:

> We had an unusual problem where a failcache entry didn't get deleted upon
> a successful build.
>
> What happened was that
> [https://build.macports.org/builders/ports-10.13_x86_64-builder/builds/88311
> libsdl built fine] but an error occurred during activation so the build
> was marked as failed. I
> [https://build.macports.org/builders/ports-10.13_x86_64-builder/builds/89833
> forced another build of libsdl] which succeeded and distributed the
> previously built archive. The install-port part of the build didn't have
> to do anything; it just printed:
>
> {{{
> libsdl already installed, nothing to do
> }}}
>
> So even though the archive was now distributed, the failcache still
> considered the port unbuildable.
>
> Maybe mpbb should clear the failcache entry when the port was already
> installed (see patch).
>
> On the other hand, in this case, the failure of libsdl to activate was
> due to a problem with the tzb2 archive (#61018), and distributing that
> broken archive isn't helpful.

New description:

 We had an unusual problem where a failcache entry didn't get deleted upon
 a successful build.

 What happened was that
 [https://build.macports.org/builders/ports-10.13_x86_64-builder/builds/88311
 libsdl built fine] but an error occurred during activation so the build
 was marked as failed. I
 [https://build.macports.org/builders/ports-10.13_x86_64-builder/builds/89833
 forced another build of libsdl] which succeeded and distributed the
 previously built archive. The install-port part of the build didn't have
 to do anything; it just printed:

 {{{
 libsdl already installed, nothing to do
 }}}

 So even though the archive was now distributed, the failcache still
 considered the port unbuildable.

 Maybe mpbb should clear the failcache entry when the port was already
 installed (see patch).

 On the other hand, in this case, the failure of libsdl to activate was due
 to a problem with the tbz2 archive (#61018), and distributing that broken
 archive isn't helpful.

--

-- 
Ticket URL: <https://trac.macports.org/ticket/61019#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS