[MacPorts] #61861: gimp-resynthesizer: uses "python2", underquoted AC_CONFIG_HEADERS, lib dependency, license

MacPorts noreply at macports.org
Fri Dec 18 09:49:16 UTC 2020


#61861: gimp-resynthesizer: uses "python2", underquoted AC_CONFIG_HEADERS, lib
dependency, license
------------------------+--------------------------------
 Reporter:  ryandesign  |      Owner:  pietvo
     Type:  defect      |     Status:  assigned
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:
 Keywords:              |       Port:  gimp-resynthesizer
------------------------+--------------------------------
 gimp-resynthesizer has a patchfile that changes `#!/usr/bin/env python` to
 `#!/usr/bin/env python2` in several python scripts. There is no `python2`
 on macOS 10.14 or earlier. You should probably change it to
 `#!/usr/bin/python` so that we're sure what python is used or add a
 dependency on port:python27 and use `#!/opt/local/bin/python2.7`.

 You also have a patch that switches to `AC_CONFIG_HEADERS` in configure.ac
 but it's underquoted. Instead of `AC_CONFIG_HEADERS(config.h)` use
 `AC_CONFIG_HEADERS([config.h])`. In any case it's an upstream issue so you
 should also submit a pull request for your configure.ac changes to the
 developers and then include the URL of that pull request in your MacPorts
 patchfile so that we can keep track of it.

 The port has a dependency on `lib:libgimp-2.0:gimp2`. That should be
 `port:gimp2`. `lib:`-style dependencies can be satisfied by software
 installed outside of MacPorts, which we don't want.

 The port specifies `license GPL-3.0`. That should be written as `license
 GPL-3` which means the same thing in MacPorts.

-- 
Ticket URL: <https://trac.macports.org/ticket/61861>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list