[MacPorts] #61861: gimp-resynthesizer: uses "python2", underquoted AC_CONFIG_HEADERS, lib dependency, license
MacPorts
noreply at macports.org
Sun Dec 20 11:35:47 UTC 2020
#61861: gimp-resynthesizer: uses "python2", underquoted AC_CONFIG_HEADERS, lib
dependency, license
---------------------------------+----------------------
Reporter: ryandesign | Owner: pietvo
Type: defect | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: gimp-resynthesizer |
---------------------------------+----------------------
Comment (by pietvo):
Replying to [comment:2 ryandesign]:
> Replying to [comment:1 pietvo]:
> > Re: the `python2`: almost all standard python plugins in `gimp2` have
`#!/usr/bin/env python2`
>
> Then they are all broken on macOS 10.14 and earlier and need to be
fixed.
I found out that these lines are interpreted by `gimp` itself, not by the
OS. It looks for `#!/usr/bin/env` and then looks up the rest in a table.
Both `python` and `python2` are mapped to `/opt/local/bin/python2.7`. So I
guess the `python2` is only chosen for documentary purposes.
This also means that my patch is both unnecessary and harmless. I'll
remove it.
>
> > `gimp2` has the default variant `+python27`, so usually the dependency
on `python2.7` is already satisfied. But if `gimp2` is installed with
`-python27` then all hope is lost, because the plugin won't work. Is there
a way to set a dependency on `gimp2` with the `python27` variant enforced?
>
> This can be accomplished using the `require_active_variants` procedure
of the active_variants 1.1 portgroup.
> {{{
> PortGroup active_variants 1.1
> require_active_variants path:lib/pkgconfig/gimp-2.0.pc:gimp2 python27
> }}}
>
I'll use that.
> > Re: the `lib:libgimp-2.0:gimp2`, this was done to catch also
`gimp2-devel`. Is there a way to specify either `gimp2` or `gimp2-devel`?
>
> Other ports use `path:lib/pkgconfig/gimp-2.0.pc:gimp2`
>
I suppose that's covered by the two lines above.
I will make the changes, test it, and submit a new PR.
--
Ticket URL: <https://trac.macports.org/ticket/61861#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list