[MacPorts] #60775: munin install issue

[MacPorts]

#60775: munin install issue
---------------------+------------------------
  Reporter:  mozzee  |      Owner:  ryandesign
      Type:  defect  |     Status:  accepted
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:
      Port:  munin   |
---------------------+------------------------
Changes (by ryandesign):

 * cc: dbevans (added)
 * owner:  (none) => ryandesign
 * status:  new => accepted
 * port:   => munin


Old description:

> Trying to install munin on my macbook pro (MacOS 10.15.5) but always
> getting following error
>
> -->  Staging munin into destroot
> Error: Failed to destroot munin: command execution failed
> Error: See
> /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/main.log
> for details.
> Error: Follow https://guide.macports.org/#project.tickets to report a
> bug.
> Error: Processing of port munin failed
>

> :info:destroot User munin nonexistent. Create the user and retry
> :info:destroot make: *** [install-pre] Error 2
> :info:destroot make: Leaving directory
> `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/munin-2.0.61'
> :info:destroot Command failed:  cd
> "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/munin-2.0.61"
> && /usr/bin/make -w install-common-prime install-node-prime install-
> plugins-prime install-plugins-java install-man install-master-prime
> PREFIX=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local
> CONFDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/etc/munin
> DBDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/var/munin
> LOGDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/var/log/munin
> STATEDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/var/run
> MANDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/share/man
> DOCDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/share/doc/munin
> LIBDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/lib/munin
> HTMLDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/www/munin
> CGIDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/www
> /cgi-bin PERL=/opt/local/bin/perl5.28 PYTHON=/opt/local/bin/python3.8
> RUBY=/opt/local/bin/ruby2.6
> DESTDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot
> :info:destroot Exit code: 2
> :error:destroot Failed to destroot munin: command execution failed
> :debug:destroot Error code: CHILDSTATUS 78272 2
> :debug:destroot Backtrace: command execution failed
> :debug:destroot     while executing
> :debug:destroot "system {*}$notty {*}$nice $fullcmdstring"
> :debug:destroot     invoked from within
> :debug:destroot "command_exec destroot"
> :debug:destroot     (procedure "portdestroot::destroot_main" line 2)
> :debug:destroot     invoked from within
> :debug:destroot "$procedure $targetname"
> :error:destroot See
> /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/main.log
> for details.

New description:

 Trying to install munin on my macbook pro (MacOS 10.15.5) but always
 getting following error

 {{{
 -->  Staging munin into destroot
 Error: Failed to destroot munin: command execution failed
 Error: See
 /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/main.log
 for details.
 Error: Follow https://guide.macports.org/#project.tickets to report a bug.
 Error: Processing of port munin failed
 }}}
 {{{
 :info:destroot User munin nonexistent. Create the user and retry
 :info:destroot make: *** [install-pre] Error 2
 :info:destroot make: Leaving directory
 `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/munin-2.0.61'
 :info:destroot Command failed:  cd
 "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/munin-2.0.61"
 && /usr/bin/make -w install-common-prime install-node-prime install-
 plugins-prime install-plugins-java install-man install-master-prime
 PREFIX=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local
 CONFDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/etc/munin
 DBDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/var/munin
 LOGDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/var/log/munin
 STATEDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/var/run
 MANDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/share/man
 DOCDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/share/doc/munin
 LIBDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/lib/munin
 HTMLDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/www/munin
 CGIDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot/opt/local/www
 /cgi-bin PERL=/opt/local/bin/perl5.28 PYTHON=/opt/local/bin/python3.8
 RUBY=/opt/local/bin/ruby2.6
 DESTDIR=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/work/destroot
 :info:destroot Exit code: 2
 :error:destroot Failed to destroot munin: command execution failed
 :debug:destroot Error code: CHILDSTATUS 78272 2
 :debug:destroot Backtrace: command execution failed
 :debug:destroot     while executing
 :debug:destroot "system {*}$notty {*}$nice $fullcmdstring"
 :debug:destroot     invoked from within
 :debug:destroot "command_exec destroot"
 :debug:destroot     (procedure "portdestroot::destroot_main" line 2)
 :debug:destroot     invoked from within
 :debug:destroot "$procedure $targetname"
 :error:destroot See
 /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_munin/munin/main.log
 for details.
 }}}

--

Comment:

 Thanks for reporting this.

 The munin port used to use the old `adduser` and `addgroup` procs in a
 `pre-destroot` block. This method was designed before MacPorts started
 distributing binaries of ports and is not compatible with binaries because
 when MacPorts installs a port from a binary it doesn't run the destroot
 phase.

 The port was updated to use the new `add_users` proc instead but it should
 have been moved outside of the `pre-destroot` block and the redundant call
 to `addgroup` should have been removed. I'll fix it.

-- 
Ticket URL: <https://trac.macports.org/ticket/60775#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS