[MacPorts] #60792: rsync: re-enable HFS compression

[MacPorts]

#60792: rsync: re-enable HFS compression
-------------------------+--------------------
  Reporter:  ryandesign  |      Owner:  (none)
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:
      Port:  rsync       |
-------------------------+--------------------

Comment (by ryandesign):

 Replying to [comment:1 jbenninghoff]:
 > > Hello, I don’t recall where I found where samba.org marked it as
 broken. My recollection is that it was in a readme file included with
 either rsync or rsync-patches. http://rsync.samba.org/ftp/rsync/rsync-
 patches-3.1.3.tar.gz is no longer available

 It's available at https://download.samba.org/pub/rsync/src/rsync-
 patches-3.1.3.tar.gz. I had already looked in there and didn't see
 anything at the top of the patch that would indicate it didn't work. I
 looked now at rsync-3.1.3.tar.gz, and didn't find any mention of "hfs" in
 it.

 > > I can tell you that I submitted the PR because I have an old PowerPC
 mac and a) rsync from an intel mac running rsync 3.1.3 to PowerPC mac
 running 3.1.2 was crashing.

 Ok thanks, that's at least something I can try to reproduce the issue. Do
 you happen to remember what OS versions you were running?

 > > I’m pretty sure I tried to get the port working with the hfs-
 compression patch but was not successful, found _something_ that said it
 was broken, so I removed it. See: https://github.com/macports/macports-
 ports/pull/1299

 Yup, I had read that PR, but it didn't say why it was broken.

 > > FWIW, the patch itself is labeled as UNTESTED, and doesn’t appear to
 have been updated in the past 9 years, since 3.1.0.dev.

 The patch seems to at least get refreshed in each rsync-patches tar.gz.
 For example, the patchfile did change between 3.2.1 and 3.2.2. (Not its
 functionality, but the line numbers in the patch.)

 Replying to [comment:2 jbenninghoff]:
 > > I seem to have found where it was marked as broken:
 > >
 > > https://github.com/WayneD/rsync-patches/blame/master/hfs-
 compression.diff#L551
 > >
 > > If you try applying the patch & compiling, this error will be kicked
 out:
 > > {{{
 > > xattrs.c:274:1: error: unknown type name '$$$ERROR$$$'
 > > $$$ERROR$$$ the old patch needs reworking since rsync_xal_get() has
 totally changed!
 > > }}}
 > >
 > > This was first added for 3.1.3, still present in 3.2.2.

 Ahhhh that explains it and gives me somewhere to look. Thanks!

-- 
Ticket URL: <https://trac.macports.org/ticket/60792#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS