[MacPorts] #60810: security/libu2f-host @1.1.7_2 does not compile due to an undeclared identifier: 'FALSE'

[MacPorts]

#60810: security/libu2f-host @1.1.7_2 does not compile due to an undeclared
identifier: 'FALSE'
----------------------+----------------------------------
 Reporter:  cshilton  |      Owner:  (none)
     Type:  defect    |     Status:  new
 Priority:  Normal    |  Milestone:
Component:  ports     |    Version:  2.6.2
 Keywords:            |       Port:  security/libu2f-host
----------------------+----------------------------------
 Port, security/libu2f-host fails to compile. Log excerpt:

 {{{
 version:1
 :debug:sysinfo macOS 10.15 (darwin/19.5.0) arch i386
 :debug:sysinfo MacPorts 2.6.2
 :debug:sysinfo Xcode 11.3
 :debug:sysinfo SDK 10.15
 :debug:sysinfo MACOSX_DEPLOYMENT_TARGET: 10.15
 :debug:main epoch: in tree: 0 installed: 0
 :debug:main xz 5.2.5_0 exists in the ports tree
 :debug:main xz 5.2.5_0  is the latest installed

 ...

 :debug:main Finished running callback portstartupitem::add_notes
 :debug:main No need to upgrade! pkgconfig 0.29.2_0 >= pkgconfig 0.29.2_0
 :debug:main epoch: in tree: 0 installed: 0
 :debug:main json-c 0.14-20200419_0 exists in the ports tree
 :debug:main json-c 0.14-20200419_0  is the latest installed
 :debug:main json-c 0.14-20200419_0  is active
 :debug:main Merging existing variants '' into variants
 :debug:main new fully merged portvariants:
 :debug:main Changing to port directory:
 /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/textproc/json-c

 ...

 :info:build u2fmisc.c:117:55: error: use of undeclared identifier 'FALSE'
 :info:build   if (u2fh_json_object_object_get (jo, "appId", k) == FALSE)
 :info:build                                                       ^
 :info:build u2fmisc.c:393:51: error: use of undeclared identifier 'FALSE'
 :info:build   if (u2fh_json_object_object_get (jo, key, k) == FALSE)
 :info:build                                                   ^
 :info:build 2 errors generated.
 }}}

 It looks like the port needs a version bump. If you the look at the source
 code repo, [https://github.com/Yubico/libu2f-host/blob/master/u2f-
 host/u2fmisc.c] for libu2f in github it mentions a version bump to the
 json.c library fromJanuary, 2020 that requires this block of C code:

 {{{

 /* json-c 0.13.99 does not define TRUE/FALSE anymore
  * the json-c maintainers replaced them with pure 1/0
  * https://github.com/json-c/json-c/commit/0992aac61f8b
  */
 #if defined JSON_C_VERSION_NUM && JSON_C_VERSION_NUM >= ((13 << 8) | 99)
 #ifndef FALSE
 #define FALSE 0
 #endif
 #ifndef TRUE
 #define TRUE  1
 #endif
 #endif

 }}}

 Looks like a version bump to 1.1.10 may fix this compile error. Dunno if
 that causes other problems.

-- 
Ticket URL: <https://trac.macports.org/ticket/60810>
MacPorts <https://www.macports.org/>
Ports system for macOS