[MacPorts] #60844: Make the reinplace warning an error

[MacPorts]

#60844: Make the reinplace warning an error
--------------------------+--------------------
  Reporter:  ryandesign   |      Owner:  (none)
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  base         |    Version:
Resolution:               |   Keywords:
      Port:               |
--------------------------+--------------------

Comment (by ryandesign):

 Replying to [comment:3 kurthindenburg]:
 > The count is a simple grep of all Portfiles.

 So you're counting how many instances of `reinplace` there are in
 Portfiles? The vast majority of those are hopefully working just fine. The
 warning is only printed for reinplaces that don't change anything.

 > I wonder if adding another flag which would change the error to a
 warning again.  The maintainers would have to research that the reinplace
 can't be fixed easily or for all XYX (macOS versions, compilers, etc) and
 then use the new flag.

 Prior to adding the existing warning, we already added a flag `-q` to
 quiet the warning, for exactly that purpose. Primarily this is intended to
 be used for batch reinplaces, for example when you need to replace a
 string in a very large number of files, and do so using fs-traverse or
 glob, but not all of the files matched contain the string to be replaced,
 and that is known and understood by the portfile developer and they wish
 to suppress the warning and take responsibility for ensuring it continues
 to work in the future.

-- 
Ticket URL: <https://trac.macports.org/ticket/60844#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS