[MacPorts] #60550: c-ares @1.16.1 does not build on PPC Tiger, Mac OS X 10.4.11, because "'for' loop initial declaration used outside C99 mode"

[MacPorts]

#60550: c-ares @1.16.1 does not build on PPC Tiger, Mac OS X 10.4.11, because
"'for' loop initial declaration used outside C99 mode"
------------------------+--------------------------
  Reporter:  ballapete  |      Owner:  tobypeterson
      Type:  defect     |     Status:  closed
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:  2.6.2
Resolution:  fixed      |   Keywords:  tiger
      Port:  c-ares     |
------------------------+--------------------------

Comment (by ryandesign):

 Replying to [comment:3 ballapete]:
 > It worked to put the line
 >
 > {{{
 > configure.cflags-append -std=c99
 > }}}
 >
 > into `Portfile`. Applying this change on the command line failed. The
 above mentioned warning was reported again.

 That's correct. MacPorts does not support for appending to, deleting from,
 or otherwise modifying portfile variables from the command line. It only
 supports overwriting them entirely, which can be used as a diagnostic
 tool.


 Replying to [comment:6 tobypeterson]:
 > I opted to patch out the C99-ism; seems less risky than changing the
 -std version for everyone.

 That's fine but note that clang has always defaulted to c99 mode so the
 only thing that setting `-std=c99` would change would be to fix the build
 failure with Apple's old gcc that defaulted to c89. If upstream adopts
 more c99isms such that patching them out becomes cumbersome, it wouldn't
 be terrible to force c99 mode, since older compilers do support that.
 We've done it in several other ports before.

-- 
Ticket URL: <https://trac.macports.org/ticket/60550#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS