[MacPorts] #61658: audio/pianod 329 update from upstream

MacPorts noreply at macports.org
Thu Nov 26 07:30:40 UTC 2020


#61658: audio/pianod 329 update from upstream
----------------------+---------------------------------
  Reporter:  perette  |      Owner:  (none)
      Type:  update   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:  haspatch maintainer
      Port:  pianod   |
----------------------+---------------------------------

Comment (by ryandesign):

 > {{{
 > -version             175
 > -revision            3
 > +version             329
 > }}}
 A `revision 0` line should remain here.

 > {{{
 > +distfiles           pianod2-${version}.tar.gz
 > }}}

 This should instead be `distname piano2-${version}`.

 > {{{
 > +checksums           rmd160  7c8eb6c4ee38d6e2cd2a1a0232457e2638f0b8c9 \
 > +                    sha256
 48f2409a0c033fc92ac90e2e4beafc736b119cdcd7532ab140f3cb32da5f7e68
 > }}}

 `size` should be added as a third checksum type.

 > {{{
 > +platform darwin 8 {
 > +depends_lib         port:curl port:taglib port:ffmpeg port:libao
 > +}
 > +
 > +platform darwin 9 {
 > +depends_lib         port:curl port:taglib port:ffmpeg port:libao
 > +}
 > }}}

 Why are ffmpeg and libao only used on Darwin 8 and 9?

 To avoid duplicating code, these two blocks should be combined into one.

 You should append to your existing depends_lib rather than overwriting it.

-- 
Ticket URL: <https://trac.macports.org/ticket/61658#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list