[MacPorts] #61192: Lots of golang ports are downloading dependencies at build time

[MacPorts]

#61192: Lots of golang ports are downloading dependencies at build time
-------------------------------------------------+-------------------------
  Reporter:  amake                               |      Owner:  (none)
      Type:  defect                              |     Status:  new
  Priority:  Normal                              |  Milestone:
 Component:  ports                               |    Version:
Resolution:                                      |   Keywords:
      Port:  annie aws-vault certigo chezmoi     |
  cloudmonkey copilot croc elvish evans fzf      |
  gitqlite glow go-migrate golangci-lint gore    |
  gotop grpcurl hugo ipfs istioctl jenkins-cli   |
  k9s krew kubergrunt kustomize micro mole       |
  newreleases pulumi rclone scw staticcheck      |
  syncthing tektoncd-cli terragrunt trivy uni    |
  up webify wtfutil yq                           |
-------------------------------------------------+-------------------------
Changes (by mf2k):

 * cc: herbygillot (removed)
 * cc: @…, @…, @…, @…, @…, @…, @…, @…, @…, @…, @…, @… (added)
 * port:   =>
     annie aws-vault certigo chezmoi cloudmonkey copilot croc elvish evans
     fzf gitqlite glow go-migrate golangci-lint gore gotop grpcurl hugo
     ipfs istioctl jenkins-cli k9s krew kubergrunt kustomize micro mole
     newreleases pulumi rclone scw staticcheck syncthing tektoncd-cli
     terragrunt trivy uni up webify wtfutil yq


Old description:

> With the introduction of the Go modules system, it's very easy to
> accidentally make a port that downloads dependencies at build time.
>
> I want to add `GOPROXY=off GO111MODULE=off` to `build.env` to prevent
> this, but there are many ports that currently fail in my testing.
>
> Discover ports using the golang-1.0 portgroup (currently 85):
>
> {{{
> find . -name Portfile | xargs grep -l -E 'PortGroup +golang' | xargs -n 1
> dirname | xargs -n 1 basename
> }}}
>
> Of those, ports that failed to build with `GOPROXY=off GO111MODULE=off`
> appended to `build.env`:
>
> - glow
> - uni
> - yq
> - krew
> - fzf
> - chezmoi
> - gotop
> - pulumi
> - k9s
> - up
> - istioctl (due to #61184)
> - certigo
> - wtfutil
> - cloudmonkey
> - kubergrunt (already reported in #61185)
> - terragrunt
> - hugo
> - micro
> - elvish
> - trivy
> - aws-vault
> - annie
> - mole
> - scw
> - croc
> - ipfs
> - rclone
> - syncthing
> - evans
> - gitqlite
> - kustomize
> - webify
> - newreleases
> - go-migrate
> - golangci-lint
> - tektoncd-cli
> - gore
> - copilot
> - jenkins-cli
> - staticcheck
> - grpcurl
>
> I have not yet checked that each of these failures is from being unable
> to download dependencies, as opposed to e.g. something more esoteric
> about `GO111MODULE`.

New description:

 With the introduction of the Go modules system, it's very easy to
 accidentally make a port that downloads dependencies at build time.

 I want to add `GOPROXY=off GO111MODULE=off` to `build.env` to prevent
 this, but there are many ports that currently fail in my testing.

 Discover ports using the golang-1.0 portgroup (currently 85):

 {{{
 find . -name Portfile | xargs grep -l -E 'PortGroup +golang' | xargs -n 1
 dirname | xargs -n 1 basename
 }}}

 Of those, ports that failed to build with `GOPROXY=off GO111MODULE=off`
 appended to `build.env`:

 ||= port =||= maintainer =||= status =||
 ||annie||@l2dy,openmaintainer||||
 ||aws-vault||@herbygillot,openmaintainer||||
 ||certigo||@herbygillot,openmaintainer||||
 ||chezmoi||@herbygillot,openmaintainer||||
 ||cloudmonkey||@herbygillot,openmaintainer||||
 ||copilot||@herbygillot,openmaintainer||||
 ||croc||@herbygillot,openmaintainer||||
 ||elvish||@herbygillot,openmaintainer||||
 ||evans||@herbygillot,openmaintainer||||
 ||fzf||@cardi,openmaintainer||||
 ||gitqlite||@herbygillot,openmaintainer||||
 ||glow||@herbygillot,openmaintainer||||
 ||go-migrate||@herbygillot,openmaintainer||||
 ||golangci-lint||@herbygillot,openmaintainer||||
 ||gore||@herbygillot,openmaintainer||||
 ||gotop||@i0ntempest,openmaintainer||||
 ||grpcurl||@herbygillot,openmaintainer||||
 ||hugo||@cardi,openmaintainer||||
 ||ipfs||@sirn,openmaintainer||||
 ||istioctl||@nickolaev,openmaintainer||due to #61184||
 ||jenkins-cli||@harens,openmaintainer||||
 ||k9s||@breun,openmaintainer||||
 ||krew||@herbygillot,openmaintainer||||
 ||kubergrunt||@herbygillot,openmaintainer||#61185||
 ||kustomize||@breun,openmaintainer||||
 ||micro||@herbygillot,openmaintainer||||
 ||mole||@herbygillot,openmaintainer||||
 ||newreleases||@herbygillot,openmaintainer||||
 ||pulumi||@herbygillot,openmaintainer||||
 ||rclone||@eborisch,openmaintainer||||
 ||scw||@dgsb,openmaintainer||||
 ||staticcheck||@herbygillot,openmaintainer||||
 ||syncthing||@lbschenkel,openmaintainer||||
 ||tektoncd-cli||@herbygillot,openmaintainer||||
 ||terragrunt||@mjrc,openmaintainer||||
 ||trivy||@herbygillot,openmaintainer||||
 ||uni||@herbygillot,openmaintainer||||
 ||up||@herbygillot,openmaintainer||||
 ||webify||@harens,openmaintainer||||
 ||wtfutil||@herbygillot,openmaintainer||||
 ||yq||@herbygillot,openmaintainer||||

 I have not yet checked that each of these failures is from being unable to
 download dependencies, as opposed to e.g. something more esoteric about
 `GO111MODULE`.

--

-- 
Ticket URL: <https://trac.macports.org/ticket/61192#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS