[MacPorts] #62642: cmake 1.1 portgroup sets -DDEBUG for the +debug variant
MacPorts
noreply at macports.org
Tue Apr 6 14:11:45 UTC 2021
#62642: cmake 1.1 portgroup sets -DDEBUG for the +debug variant
-----------------------+--------------------
Reporter: szhorvat | Owner: (none)
Type: defect | Status: new
Priority: Normal | Milestone:
Component: base | Version: 2.6.4
Resolution: | Keywords:
Port: |
-----------------------+--------------------
Comment (by RJVB):
I don't know if you're referring to an official standard here, but a quick
search on linux (`fgrep ' DEBUG' -R /usr/include`) shows that the `DEBUG`
token isn't that uncommon as you seem to think. And that frankly stands to
reason given that the explicit opposite (`NDEBUG`) is an apparently less
disputed standard.
I'm not in favour of changing this given that apparently it is an issue
only now and only with a single port, not knowing how many users depend on
the fact that `DEBUG` is being defined. If it weren't for that I'd
probably concur with you that ports could add the token definition (and
even then, most port maintainers are not also developers of the software
provided by their port so you can't expect them to know this kind of
detail).
As it stands I'd say it's easier for ports where this definition does pose
a problem to filter it out from the standard debug options set by +debug.
That's not currently supported in the released version of the PG I see.
I'll attach a patch that achieves this ASAP.
--
Ticket URL: <https://trac.macports.org/ticket/62642#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list