[MacPorts] #62642: cmake 1.1 portgroup sets -DDEBUG for the +debug variant
MacPorts
noreply at macports.org
Wed Apr 7 10:43:52 UTC 2021
#62642: cmake 1.1 portgroup sets -DDEBUG for the +debug variant
-----------------------+--------------------
Reporter: szhorvat | Owner: (none)
Type: defect | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 2.6.4
Resolution: | Keywords:
Port: |
-----------------------+--------------------
Comment (by RJVB):
My point exactly (but quantified :)). One of the places where I found use
of the token is in X11 headers. Which stands to reason as their use of it
probably goes back even further than mine. It's all nice and well that
`NDEBUG` was added to a C standard somewhere in the very late 90s (if
that's indeed what C99 stands for), but C had been around for a very long
time already by then. It beats me why no one saw a need to include a token
that's the opposite of `NDEBUG` (maybe the standard drafters consider
debug builds the default?!). For me use of the token was clearly obvious
enough not to see any need to document its inclusion in the `+debug`
variant - which btw is intended to build software with the maximum
possible amount of debugging info.
I was planning to attach just a patchfile but since I saw a few other
minor usability improvements in my own version of the PG I decide to throw
them in and create a PR after all:
https://github.com/macports/macports-ports/pull/10610
--
Ticket URL: <https://trac.macports.org/ticket/62642#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list