[MacPorts] #64142: New Port - ntpstat
MacPorts
noreply at macports.org
Mon Dec 6 03:12:32 UTC 2021
#64142: New Port - ntpstat
-------------------------+--------------------
Reporter: RobK88 | Owner: (none)
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 2.7.1
Resolution: | Keywords:
Port: ntpstat |
-------------------------+--------------------
Comment (by ryandesign):
The `version` you've selected in the file... "20010622"... are you basing
that on the date at the top of the manpage and the comment at the top of
the source file?
The project was committed to GitHub in 2013, by someone other than the
author listed in the source file, and the repository has only one commit
of the source and one commit of a binary that we don't want, which makes
me think this is not the original or official source of this software.
It looks like this is the last archived copy of the official homepage:
https://web.archive.org/web/20121207230716/http://people.redhat.com/rkeech/#ntpstat
That page links to a source code archive called ntpstat-0.2-1.src.rpm so I
think that means we should set `version` to "0.2".
We may want to try to contact the developer at the listed email address or
do additional internet searches to try to discover if there is a new home
for this software from which we could get it.
If we were to download the source code from GitHub, then we'd want to use
the github 1.0 portgroup to simplify the Portfile. However, since that's
not the original source, I'd be inclined to use a more official source if
available. If no new home is available we could try to use the above
source rpm but I'm not sure if MacPorts knows how to decompress an rpm
file.
And if we were to download from GitHub, then it's not permitted to
download the head of "master" or another branch of a repository in a
Portfile. Instead, you must select a specific tag or commit, so that
[wiki:ReproducibleBuilds builds are reproducible]. For example, we might
select the initial commit, since that will be a smaller archive since it
won't contain the binary we don't need.
In your patchfile which comments out the line `#include <error.h>`, it
would be simpler and more efficient for the patchfile to ''remove'' that
line.
I wouldn't bother including the entire GPL license file in the files
directory. It is several times the size of the Portfile and patches. If
every port did that, it would be an incredible waste of space. The
software already includes a COPYING file which, while it doesn't have the
entire license text, does say what license it is, and installing that
should be sufficient.
I am assuming in all of this that there is some value in adding this 20
+-year-old program to MacPorts at this point that is not already met by
one of our other ports.
--
Ticket URL: <https://trac.macports.org/ticket/64142#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list