[MacPorts] #62260: github and bitbucket portgroups: Remove post-extract block

MacPorts noreply at macports.org
Thu Feb 11 09:39:51 UTC 2021


#62260: github and bitbucket portgroups: Remove post-extract block
------------------------+------------------------------
 Reporter:  ryandesign  |      Owner:  (none)
     Type:  defect      |     Status:  new
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:
 Keywords:              |       Port:  github bitbucket
------------------------+------------------------------
 The github 1.0 portgroup's post-extract block exists so that
 automatically-generated "tarball"-type distfiles, which have enclosing
 directory names that contain the commit hash, can be automatically renamed
 to the name that the port expects (`$distname`).

 This code was never properly guarded against other download types. It
 should never have taken effect for "download" or "release"-type distfiles,
 but does, which causes problems in some cases; see comments on
 [5c5ec4019e9dafb7d80a068a00b5a9b7e4585f0e/macports-ports].

 The entire post-extract block should be superfluous as of MacPorts 2.6.0
 which creates a symlink of the expected name for you. I am testing the
 deletion of this block in my local ports tree and will commit it if no
 problems are found after awhile.

 The bitbucket 1.0 portgroup, having been based on the github 1.0.
 portgroup, has this block too.

 The gitlab 1.0 portgroup, having been based on these portgroups, has this
 block too, but there it is already commented out.

-- 
Ticket URL: <https://trac.macports.org/ticket/62260>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list