[MacPorts] #61956: mc opportunistically links with libssh2

[MacPorts]

#61956: mc opportunistically links with libssh2
------------------------+--------------------
 Reporter:  ryandesign  |      Owner:  (none)
     Type:  defect      |     Status:  new
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:  2.6.99
 Keywords:              |       Port:  mc
------------------------+--------------------
 mc links with a library from the libssh2 port, even though it does not
 declare a dependency on it:
 {{{
 $ sudo port -s install mc
 --->  Computing dependencies for mc
 --->  Fetching distfiles for mc
 --->  Verifying checksums for mc
 --->  Extracting mc
 --->  Applying patches to mc
 --->  Configuring mc
 --->  Building mc
 --->  Staging mc into destroot
 --->  Installing mc @4.8.25_0+slang2
 --->  Activating mc @4.8.25_0+slang2
 --->  Cleaning mc
 $ otool -L /opt/local/bin/mc
 /opt/local/bin/mc:
         /opt/local/lib/libslang.2.dylib (compatibility version 2.0.0,
 current version 2.2.0)
         /opt/local/lib/libssh2.1.dylib (compatibility version 2.0.0,
 current version 2.1.0)
         /opt/local/lib/libglib-2.0.0.dylib (compatibility version
 5801.0.0, current version 5801.3.0)
         /opt/local/lib/libintl.8.dylib (compatibility version 10.0.0,
 current version 10.7.0)
         /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current
 version 1252.50.4)
 $ port prov /opt/local/lib/libssh2.1.dylib
 /opt/local/lib/libssh2.1.dylib is provided by: libssh2
 $ port deps mc
 Full Name: mc @4.8.25_0+slang2
 Extract Dependencies: xz
 Build Dependencies:   pkgconfig
 Library Dependencies: glib2, slang2
 $
 }}}
 There is already an sftp variant which adds a build dependency on libssh2.
 So 2 things are wrong:

 1. the port needs to be changed so that it does not link with libssh2 even
 if it is already installed unless the sftp variant is selected
 2. the sftp variant needs to add libssh2 as a library dependency, not a
 build dependency

 Both of these changes warrant increasing the port's revision.

-- 
Ticket URL: <https://trac.macports.org/ticket/61956>
MacPorts <https://www.macports.org/>
Ports system for macOS