[MacPorts] #62162: qemu: incompatible mktemp usage

[MacPorts]

#62162: qemu: incompatible mktemp usage
-------------------------+----------------------
 Reporter:  Ionic        |      Owner:  raimue
     Type:  enhancement  |     Status:  assigned
 Priority:  Low          |  Milestone:
Component:  ports        |    Version:
 Keywords:               |       Port:  qemu
-------------------------+----------------------
 Apple's version of `mktemp` is different enough from the GNU coreutils one
 to potentially cause issues.

 Most importantly, it does not support the `-p`/`--tmpdir` flags. This is
 also true for the most recent version in macOS 11.0.1.

 Some scripts within qemu use them, but, luckily, these scripts are either
 part of tests we don't run currently xor are not executed as part of the
 build process, but rather meant to be executed manually by upstream
 project maintainers.

 So... fixing this would strictly speaking be redundant. On the other hand,
 we might still want to do this in case we're enabling tests (or the like)
 later on. The downside of that is dragging a patch along changing 7 files,
 not currently using any functionality it changes and having to rebase and
 update it potentially with every qemu version update.

 What's your take on it? Do you want it? Or should we rather keep it as-is
 and maybe deal with that issue whenever (if it ever) bites us?

 Suggested patch attached.

 ----

 I'd like to apply the other patch for old systems/older `mktemp` versions
 that don't support being called without an argument unconditionally, since
 the affected scripts might be executed in variants. Since this is for
 older systems only, though, you don't need to care.

-- 
Ticket URL: <https://trac.macports.org/ticket/62162>
MacPorts <https://www.macports.org/>
Ports system for macOS