[MacPorts] #62240: hfstar has conflicting message files with gnutar

[MacPorts]

#62240: hfstar has conflicting message files with gnutar
----------------------------+--------------------
  Reporter:  rlhamil        |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.6.4
Resolution:                 |   Keywords:
      Port:  hfstar gnutar  |
----------------------------+--------------------

Comment (by cooljeanius):

 > He also mentioned the possibility that as ancient as hfstar is, its
 unique features MIGHT have been subsumed into guitar, making it obsolete.
 Perhaps that's worth checking, too.

 Note that another symptom of it being ancient and obsolete is that it runs
 into the usual implicit function declaration issues that result from
 `-Werror=implicit-function-declaration` being on by default on Catalina
 and Big Sur, too:

 {{{
 error.c:175:7: error: implicit declaration of function 'strerror_r' is
 invalid in C99 [-Werror,-Wimplicit-function-declaration]
       __strerror_r (errnum, errbuf, sizeof errbuf);
       ^
 error.c:101:24: note: expanded from macro '__strerror_r'
 #  define __strerror_r strerror_r
                        ^
 error.c:216:36: error: implicitly declaring library function 'strcmp' with
 type 'int (const char *, const char *)' [-Werror,-Wimplicit-function-
 declaration]
           (file_name == old_file_name || !strcmp (old_file_name,
 file_name)))
                                           ^
 error.c:216:36: note: include the header <string.h> or explicitly provide
 a declaration for 'strcmp'
 error.c:257:7: error: implicit declaration of function 'strerror_r' is
 invalid in C99 [-Werror,-Wimplicit-function-declaration]
       __strerror_r (errnum, errbuf, sizeof errbuf);
       ^
 error.c:101:24: note: expanded from macro '__strerror_r'
 #  define __strerror_r strerror_r
                        ^
 3 errors generated.
 make[2]: *** [error.o] Error 1
 make[2]: *** Waiting for unfinished jobs....
 dirname.c:68:3: error: implicitly declaring library function 'memcpy' with
 type 'void *(void *, const void *, unsigned long)' [-Werror,-Wimplicit-
 function-declaration]
   memcpy (newpath, path, length);
   ^
 dirname.c:68:3: note: include the header <string.h> or explicitly provide
 a declaration for 'memcpy'
 1 error generated.
 argmatch.c:69:3: error: implicitly declaring library function 'exit' with
 type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-
 declaration]
   ARGMATCH_DIE;
   ^
 argmatch.c:59:23: note: expanded from macro 'ARGMATCH_DIE'
 # define ARGMATCH_DIE exit (EXIT_FAILURE)
                       ^
 argmatch.c:69:3: note: include the header <stdlib.h> or explicitly provide
 a declaration for 'exit'
 argmatch.c:59:23: note: expanded from macro 'ARGMATCH_DIE'
 # define ARGMATCH_DIE exit (EXIT_FAILURE)
                       ^
 argmatch.c:99:12: error: implicitly declaring library function 'strlen'
 with type 'unsigned long (const char *)' [-Werror,-Wimplicit-function-
 declaration]
   arglen = strlen (arg);
            ^
 argmatch.c:99:12: note: include the header <string.h> or explicitly
 provide a declaration for 'strlen'
 argmatch.c:105:7: error: implicitly declaring library function 'strncmp'
 with type 'int (const char *, const char *, unsigned long)' [-Werror
 ,-Wimplicit-function-declaration]
           ? !strncmp (arglist[i], arg, arglen)
              ^
 argmatch.c:105:7: note: include the header <string.h> or explicitly
 provide a declaration for 'strncmp'
 argmatch.c:106:7: error: implicitly declaring library function
 'strncasecmp' with type 'int (const char *, const char *, unsigned long)'
 [-Werror,-Wimplicit-function-declaration]
           : !strncasecmp (arglist[i], arg, arglen))
              ^
 argmatch.c:106:7: note: include the header <strings.h> or explicitly
 provide a declaration for 'strncasecmp'
 make[2]: *** [dirname.o] Error 1
 argmatch.c:118:8: error: implicitly declaring library function 'memcmp'
 with type 'int (const void *, const void *, unsigned long)' [-Werror
 ,-Wimplicit-function-declaration]
                   || memcmp (vallist + valsize * matchind,
                      ^
 argmatch.c:118:8: note: include the header <string.h> or explicitly
 provide a declaration for 'memcmp'
 modechange.c:478:7: error: implicit declaration of function 'free' is
 invalid in C99 [-Werror,-Wimplicit-function-declaration]
       free (changes);
       ^
 1 error generated.
 5 errors generated.
 make[2]: *** [modechange.o] Error 1
 make[2]: *** [argmatch.o] Error 1
 make[2]: Leaving directory
 `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_hfstar/hfstar/work/hfstar/lib'
 make[1]: *** [all-recursive] Error 1
 make[1]: Leaving directory
 `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_hfstar/hfstar/work/hfstar'
 make: *** [all-recursive-am] Error 2
 make: Leaving directory
 `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_hfstar/hfstar/work/hfstar'
 Command failed:  cd
 "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_hfstar/hfstar/work/hfstar"
 && /usr/bin/make -j16 -w all
 Exit code: 2
 Error: Failed to build hfstar: command execution failed
 DEBUG: Error code: CHILDSTATUS 10542 2
 }}}

 (should I open a separate bug for that, or are we just going to say that
 since it's obsolete it's not worth bothering?)

-- 
Ticket URL: <https://trac.macports.org/ticket/62240#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS