[MacPorts] #62458: yabai @3.3.6: implicit declaration of functions when building for i386

[MacPorts]

#62458: yabai @3.3.6: implicit declaration of functions when building for i386
------------------------+------------------------
 Reporter:  ryandesign  |      Owner:  macports@…
     Type:  defect      |     Status:  assigned
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:  2.6.99
 Keywords:              |       Port:  yabai
------------------------+------------------------
 On High Sierra, yabai doesn't build for i386 (neither i386 alone nor
 universal when i386 is among the archs) if I request that implicit
 declaration of functions be treated as an error:

 {{{
 $ sudo port -dns build yabai build_arch=i386 configure.objcflags="-Os
 -Werror=implicit-function-declaration"
 }}}
 {{{
 :info:build ./src/osax/payload.m:207:57: error: implicit declaration of
 function 'get_dock_spaces_offset' is invalid in C99 [-Werror,-Wimplicit-
 function-declaration]
 :info:build     uint64_t dock_spaces_addr = hex_find_seq(baseaddr +
 get_dock_spaces_offset(os_version), get_dock_spaces_pattern(os_version));
 :info:build                                                         ^
 :info:build ./src/osax/payload.m:207:93: error: implicit declaration of
 function 'get_dock_spaces_pattern' is invalid in C99 [-Werror,-Wimplicit-
 function-declaration]
 :info:build     uint64_t dock_spaces_addr = hex_find_seq(baseaddr +
 get_dock_spaces_offset(os_version), get_dock_spaces_pattern(os_version));
 :info:build
 ^
 }}}
 etc.

 It does build successfully for i386 when not specifying `-Werror=implicit-
 function-declaration`.

 It does build successfully for x86_64 whether or not I specify `-Werror
 =implicit-function-declaration`.

-- 
Ticket URL: <https://trac.macports.org/ticket/62458>
MacPorts <https://www.macports.org/>
Ports system for macOS