[MacPorts] #62530: pull request CI checks are marked successful even when they fail

[MacPorts]

#62530: pull request CI checks are marked successful even when they fail
----------------------------+---------------------
  Reporter:  ryandesign     |      Owner:  admin@…
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  buildbot/mpbb  |    Version:
Resolution:                 |   Keywords:
      Port:                 |
----------------------------+---------------------
Changes (by neverpanic):

 * cc: herbygillot (added)


Comment:

 This was a conscious decision to not fail a CI build because the
 dependencies failed to install, since we time and time merged changes with
 failed CI builds that only failed due to a problem in a dependency, not in
 the actual port itself.

 Of course, in this particular example, the person that merged this should
 have noticed the lint warnings about the unknown dependencies that were
 posted as comments to the change by the CI system. Developers should not
 just ignore such warnings when merging pull requests.

 The fix is adding {{{fail=1}}} between the lines
 https://github.com/macports/macports-ports/blob/master/.github/azure-
 workflows/main.yml#L135-L136 and https://github.com/macports/macports-
 ports/blob/master/.github/workflows/main.yml#L140-L141.

-- 
Ticket URL: <https://trac.macports.org/ticket/62530#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS