[MacPorts] #62530: pull request CI checks are marked successful even when they fail

[MacPorts]

#62530: pull request CI checks are marked successful even when they fail
----------------------------+---------------------
  Reporter:  ryandesign     |      Owner:  admin@…
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  buildbot/mpbb  |    Version:
Resolution:                 |   Keywords:
      Port:                 |
----------------------------+---------------------

Comment (by mojca):

 I recently made a PR with tons of different python packages (just for the
 sake of adding py39 subport) in addition to the main package that switched
 from python 3.8 to 3.9. I nearly oversaw the fact that some packages
 failed to build, and the log was so long that it was basically impossible
 to figure out what built and what didn't. I only tested some of the
 packages, but everything was green, so I felt comfortable merging and
 almost did that, I only later noticed livecheck warnings.

 I fail to understand why it's better to deliberately mark a build a
 successful. If a dependency fails, the main port won't even be checked. At
 all. And yet it will be shown in green. If the build fails and is marked
 with the red color, it's still straightforward to check why the build fail
 and deliberately decide that it's still ok to merge something. It's not
 like we prevent merging failed builds.

 Combined with the fact that we are no longer receiving emails with build
 failures, that's a perfect recipe to never notice a failed build: neither
 before nor after the merge.

-- 
Ticket URL: <https://trac.macports.org/ticket/62530#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS