[MacPorts] #62890: openssh 8.4p1 does not compile with +fido2 variant

[MacPorts]

#62890: openssh 8.4p1 does not compile with +fido2 variant
--------------------+---------------------
 Reporter:  iay     |      Owner:  (none)
     Type:  defect  |     Status:  new
 Priority:  Normal  |  Milestone:
Component:  ports   |    Version:
 Keywords:          |       Port:  openssh
--------------------+---------------------
 I wanted to investigate the +fido2 variant to experiment with GitHub's new
 support for security keys, per https://github.blog/2021-05-10-security-
 keys-supported-ssh-git-operations/

 However, trying to install `openssh +fido2` fails. This is the critical
 part of the log:

 {{{
 In file included from sk-usbhid.c:30:
 /opt/local/include/sha2.h:57:16: error: redefinition of '_SHA2_CTX'
 typedef struct _SHA2_CTX {
                ^
 ./openbsd-compat/sha2.h:66:16: note: previous definition is here
 typedef struct _SHA2_CTX {
                ^
 In file included from sk-usbhid.c:30:
 /opt/local/include/sha2.h:64:3: error: typedef redefinition with different
 types ('struct (anonymous struct at /opt/local/include/sha2.h:57:16)' vs
 'struct _SHA2_CTX')
 } SHA2_CTX;
   ^
 ./openbsd-compat/sha2.h:73:3: note: previous definition is here
 } SHA2_CTX;
   ^
 }}}

 Rather than trying to address this via a patch, I noted that we're a
 couple of releases behind as upstream is now at 8.6p1.

 I have developed a PR for openssh which updates to 8.6p1; it does allow
 building with `+fido2` and some basic experiments seem to confirm that
 functionality is working (not vs. GitHub yet, but against a local test
 machine running Ubuntu 20.04).

 Copying Schamschula because he seems to be the most recently active on
 this no-maintainer project and also because my PR necessarily backs out
 one of his previous patches (which was explicitly labelled as to be
 removed on or after 8.5p1).

 I will submit my PR probably later today.

-- 
Ticket URL: <https://trac.macports.org/ticket/62890>
MacPorts <https://www.macports.org/>
Ports system for macOS