[MacPorts] #63033: Notes on Godot 3.3.2 and legacy OS's.

[MacPorts]

#63033: Notes on Godot 3.3.2 and legacy OS's.
------------------------------------+------------------------
  Reporter:  Wowfunhappy            |      Owner:  jasonliu--
      Type:  enhancement            |     Status:  assigned
  Priority:  Low                    |  Milestone:
 Component:  ports                  |    Version:  2.7.1
Resolution:                         |   Keywords:
      Port:  godot macports-libcxx  |
------------------------------------+------------------------
Changes (by ryandesign):

 * status:  new => assigned
 * owner:  (none) => jasonliu--


Comment:

 Replying to [ticket:63033 Wowfunhappy]:
 > == 2.
 >
 > For a reason I wasn't able to track down, the lines:
 >
 > {{{
 > #if MAC_OS_X_VERSION_MAX_ALLOWED < 101200
 > #if MAC_OS_X_VERSION_MAX_ALLOWED >= 101200
 > }}}
 >
 > in `platform/osx/os_osx.mm` no longer have the desired effect; the
 compiler is convinced MAX_ALLOWED is always above 101200. I had to
 manually comment out the relevant blocks of code.
 >
 > There is probably a better way to fix this.


 This commenting out (removing) was committed in
 [b08699befa86acc41878c689093eb35d25aed0a9/macports-ports].

 I suspect the reason for the problem is that platform/osx/detect.py sets
 `-mmacosx-version-min=10.12` on x86_64 systems (while still printing an
 inaccurate message "Building for macOS 10.9+, platform x86-64"). The
 setting of `-macosx-version-min` should probably be removed from the build
 system since MacPorts already sets the equivalent MACOSX_DEPLOYMENT_TARGET
 environment variable the way it wants.

 This would have been easier to notice if the build did not use silent
 rules; the portfile should disable silent rules (i.e. we should see each
 compile command and all its arguments in the log).

-- 
Ticket URL: <https://trac.macports.org/ticket/63033#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS