[MacPorts] #63349: qemu: Update to version 6.0
MacPorts
noreply at macports.org
Sat Sep 11 03:42:38 UTC 2021
#63349: qemu: Update to version 6.0
----------------------------------+--------------------
Reporter: IComplainInComments | Owner: (none)
Type: update | Status: closed
Priority: Normal | Milestone:
Component: ports | Version: 2.7.1
Resolution: fixed | Keywords:
Port: qemu |
----------------------------------+--------------------
Changes (by ryandesign):
* status: new => closed
* resolution: => fixed
* type: submission => update
Comment:
Yes. By submitting a ticket or pull request to update a port, you are
requesting that permission. The maintainer can then respond or if they
don't within 3 days, another committer can do so.
Your submission contained many errors:
* Your master_sites was wrong. (It needs to be the URL to the directory
containing the file, not the URL to the file.)
* If you wanted to download and extract a tar.xz file, you needed to have
added the line `use_xz yes`.
* You listed many build dependencies in depends_lib. (They go in
depends_build.)
* You didn't use `path:` dependency syntax for those ports that have
alternatives (glib2, libpixman).
* You used pkgconf instead of pkgconfig. pkgconf was recently added to
MacPorts but so far only one port uses it (and it's unclear whether even
that was necessary). Perhaps we need to modify all ports that use pkgconf
or pkgconfig to use `path:` syntax to allow the user to choose which one
they want.
* You hardcoded /opt/local. You must use ${prefix} instead.
* You specified the prefix in configure.args. MacPorts already sets the
prefix for you in configure.pre_args.
* You specified a configure argument for enabling libusb support but did
not specify a dependency on the libusb port.
* Your description was not detailed enough.
* You didn't not specify the port's license.
* There was an unnecessary comment line at the top of the portfile.
* You didn't name the file "Portfile"
* You seem to have created this file from scratch rather than basing it on
the existing qemu portfile. If we offer multiple portfiles for different
versions of the same software, the portfiles should be as similar as
possible and ideally maintained by the same person.
In the mean time, [https://github.com/macports/macports-ports/pull/11932
pull request 11932] was submitted to update the port to 6.0.0. It was
closed in preference to [https://github.com/macports/macports-
ports/pull/11989 pull request 11989] which updated the port to 6.1.0 and
which has been merged.
Pull requests are the preferred way to submit new ports and port updates
because it enables easier discussion about specific line changes and
automatically performs trial builds.
--
Ticket URL: <https://trac.macports.org/ticket/63349#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list