[MacPorts] #65059: got-portable (gameoftrees) preliminary attempt at a Portfile

[MacPorts]

#65059: got-portable (gameoftrees) preliminary attempt at a Portfile
-------------------------+--------------------
  Reporter:  artkiver    |      Owner:  (none)
      Type:  submission  |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:
      Port:              |
-------------------------+--------------------

Comment (by ryandesign):

 Thanks. New ports and changes to existing ports can be submitted directly
 as pull requests without filing a Trac ticket first. Changes are easier to
 review on GitHub and automated CI builds happen for pull requests,
 enabling us to see whether your submission builds or not without having to
 download it and try it manually. If you are not comfortable using GitHub,
 it is acceptable to submit new ports or changes as tickets in Trac.

 > {{{
 > PortGroup           muniversal 1.0
 > }}}

 What makes this require the muniversal portgroup?

 > {{{
 > platforms           darwin
 > }}}

 This line appears twice in your Portfile. Both can be removed as this is
 now the default.

 > {{{
 > master_sites        https://gameoftrees.org/releases/portable/
 > }}}

 To avoid duplication, the homepage variable can be referenced here:

 {{{
 master_sites        ${homepage}releases/portable/
 }}}

 > {{{
 > depends_build       port:automake \
 > }}}

 Depending only on automake is suspicious. Normally automake, autoconf and
 libtool are used together. And normally MacPorts will add these
 dependencies for you when you specify `use_autoreconf yes`, which you
 didn't. Normally you only need these dependencies if you are rebuilding
 the build system. Are you? Or does this build system use `automake` in
 some unusual way? I think the automake dependency can just be removed; it
 still built fine (in trace mode) when I removed it.

 > {{{
 >                     port:bison \
 >                     port:pkgconfig \
 > }}}

 Remove the trailing slash after "pkgconfig".

 This warning appears when configuring:

 > {{{
 > Warning: Configuration logfiles contain indications of -Wimplicit-
 function-declaration; check that features were not accidentally disabled:
 >   recallocarray: found in got-portable-0.68.1/config.log
 >   reallocarray: found in got-portable-0.68.1/config.log
 >   strchr: found in got-portable-0.68.1/config.log
 > }}}

 `recallocarray` and `reallocarray` are unfamiliar to me. Looks like they
 are BSD functions that are not in any macOS version. So they should be
 added to the [browser:macports-
 ports/_resources/port1.0/checks/implicit_function_declaration/ global
 exclusion files].

 `strchr` is a standard function but current configure scripts contain a
 test that deliberately fails to include the required header in order to
 see how the compiler reacts to that. Since the vintage of the configure
 script is specific to each project, this Portfile should have the
 following line added to suppress this warning:

 {{{
 configure.checks.implicit_function_declaration.whitelist-append strchr
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/65059#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS