[MacPorts] #64607: fix for libtheora to build on 10.6.8 Rosetta

[MacPorts]

#64607: fix for libtheora to build on 10.6.8 Rosetta
---------------------------+-------------------------------------------
  Reporter:  barracuda156  |      Owner:  (none)
      Type:  submission    |     Status:  new
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:  2.7.1
Resolution:                |   Keywords:  powerpc, snowleopard, rosetta
      Port:  libtheora     |
---------------------------+-------------------------------------------

Comment (by kencu):

 For MacPorts to accept a fix into either base or into a Portfile, it has
 to be what you would call a "pure, true fix". Anything else is, in the
 long run, going to be more trouble than it is worth.

 You can see many many many examples all throughout the PRs and tickets and
 discussion lists from people who have found some workaround or another for
 their build or install problem that works for them on the machine they
 have in front of them.

 No argument about that, and more power to them! They have something that
 works for them.

 The problem comes when they want to share their proudly-discovered HACK
 with the world. Hacks like that almost always wind up being a big disaster
 in the end, once the build spreads to more systems, newer systems, other
 systems, etc. They cause a LOT of headaches.

 I have been guilty of this myself at times, for sure. There are a number
 of HACK PRs in the PR queue now that will probably never be allowed into
 MacPorts, nor should they be.

 So -- what you have found here works for you. That is great.

 It will never be allowed into MacPorts like this, though, nor should it
 be.

 That is great too!

-- 
Ticket URL: <https://trac.macports.org/ticket/64607#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS