[MacPorts] #57248: cargo opportunistically uses http-parser
MacPorts
noreply at macports.org
Sat Jan 8 20:05:17 UTC 2022
#57248: cargo opportunistically uses http-parser
-------------------------+-------------------------
Reporter: ryandesign | Owner: herbygillot
Type: defect | Status: closed
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: fixed | Keywords:
Port: cargo |
-------------------------+-------------------------
Changes (by ryandesign):
* status: assigned => closed
* resolution: => fixed
Comment:
Thanks for checking. I also can't reproduce it now. Building cargo, I see
no occurrences of the case-insensitive regex `http.parser` in the log.
Checking the extracted source, I do see references to http-parser in
.home/.cargo/macports/libgit2-sys-0.12.26+1.3.0/libgit2 and
.home/.cargo/macports/libnghttp2-sys-0.1.7+1.45.0/nghttp2.
libgit2-sys could have been the culprit.
I'm not clear on the relationship between libgit2-sys and git2.
libgit2-sys seems to be a subproject of git2 but both of them are listed
in the cargo Portfile.
When I filed this ticket in October 2018, the cargo port was at version
0.24.0 and was [https://github.com/macports/macports-
ports/blob/ed645cc03c46e4d41fae0370b06777abbd6e89ce/devel/cargo/Portfile#L214
using git2 0.7.5] and libgit2-sys 0.7.10.
At that time libgit2-sys had a bundled copy of http-parser but only used
it when cross-compiling.
In September 2018 libgit2-sys switched to [https://github.com/rust-
lang/git2-rs/commit/76f4b74aef2bc2a54906ddcbf7fbe0018936a69d#diff-
a47103f5ffeb9ec422f9ec9df7b22d8da3450b1a0df531d20a43bc4265dc1c85R50 always
using the bundled http-parser].
The cargo port didn't update to the fixed 0.8.0 version of git2 until the
cargo port was [changeset:0b0a89f5e1aa923750b15e71bf509e3e165ecc27
/macports-ports updated to 0.36.0] in June 2019.
Or, since libgit2-sys was still at 0.7.11 at that point, maybe it didn't
get fixed until cargo was
[changeset:8fc7886c4edfa792c56f58a053b0f223ebe5279f/macports-ports updated
to 0.40.0] and libgit2-sys 0.9.2 in November 2019.
So let's call it fixed by some update.
--
Ticket URL: <https://trac.macports.org/ticket/57248#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list