[MacPorts] #64427: libgphoto2: builds failing on some buildbots

[MacPorts]

#64427: libgphoto2: builds failing on some buildbots
-------------------------+------------------------
  Reporter:  mascguy     |      Owner:  ryandesign
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.7.1
Resolution:              |   Keywords:
      Port:  libgphoto2  |
-------------------------+------------------------

Comment (by mascguy):

 I took a quick look at this port's `configure.ac`, relative to the various
 compiler flags. And this comment block calls out a solution:

 {{{
 dnl --------------------------------------------------------------------
 dnl The goals here are twofold:
 dnl
 dnl   * Produce as many compiler warnings as possible to find
 dnl     potential problems in our own code.
 dnl
 dnl   * Make sure our API header files are as broadly compatible as
 dnl     possible.
 dnl
 dnl We want our library and driver code to compile with the lowest
 dnl possible number of warnings, and the pedantic compilation tests to
 dnl compile with zero warnings (-Werror) so we do not limit the users
 dnl of our API in their use of compiler warnings.
 dnl
 dnl If, for some reason, you need to build without all these compiler
 dnl warnings, run the build while setting CFLAGS to an empty string:
 dnl
 dnl     $ make all check CFLAGS=
 dnl --------------------------------------------------------------------
 }}}

 So one easy solution is to simply specify `CFLAGS` to Make, during the
 build phase. Tested locally with the following one-line change, and this
 indeed fixes the issue:

 {{{
 build.args-append   CFLAGS="${configure.cflags}"
 }}}

 Ryan, this fix - along with a comment block elaborating on all of the
 above - is ready for commit. Do you mind if I go ahead and push that
 change, to fix this port? Or would you prefer to take a different
 approach?

-- 
Ticket URL: <https://trac.macports.org/ticket/64427#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS