[MacPorts] #64551: freeciv @2.6.6: X11 config tests gives -Wimplicit-function-declaration warning on exit, strcmp

[MacPorts]

#64551: freeciv @2.6.6: X11 config tests gives -Wimplicit-function-declaration
warning on exit, strcmp
--------------------+----------------------
 Reporter:  JDLH    |      Owner:  JDLH
     Type:  defect  |     Status:  assigned
 Priority:  Normal  |  Milestone:
Component:  ports   |    Version:  2.7.1
 Keywords:          |       Port:  freeciv
--------------------+----------------------
 When building freeciv @2.6.6 (work in progress, a major rewrite, see
 #62984), MacPorts prints a warning, "indications of -Wimplicit-function-
 declaration", regarding functions named `strcmp` and `exit`. These appear
 to be true positives. The configuration code which the port uses fails to
 include `<string.h>` and `<stdlib.h>`.

 This is the initial warning from MacPorts:
 {{{
 % sudo port build freeciv-common
 --->  Computing dependencies for freeciv-common
 --->  Fetching distfiles for freeciv-common
 --->  Verifying checksums for freeciv-common
 --->  Extracting freeciv-common
 --->  Configuring freeciv-common
 Warning: Configuration logfiles contain indications of -Wimplicit-
 function-declaration; check that features were not accidentally disabled:
   strcmp: found in freeciv-2.6.6/config.log
   exit: found in freeciv-2.6.6/config.log
   at_quick_exit: found in freeciv-2.6.6/config.log
 --->  Building freeciv-common
 %
 }}}

 I plan to make patches to the config code to include those headers, as
 part of the #62984 rewrite. I also plan to submit those patches to the
 upstream code base.

-- 
Ticket URL: <https://trac.macports.org/ticket/64551>
MacPorts <https://www.macports.org/>
Ports system for macOS