[MacPorts] #65270: Fish 3.4.1 fails to compile on Leopard PPC

[MacPorts]

#65270: Fish 3.4.1 fails to compile on Leopard PPC
-----------------------+--------------------
  Reporter:  acjones8  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:  2.7.2
Resolution:            |   Keywords:
      Port:  fish      |
-----------------------+--------------------

Comment (by acjones8):

 Alright, I've been working on this, and I think I've found some solutions.

 The last git revision that worked before it fails is ae1a507 , which I
 believe is version 3.1.2 if memory serves me correct. This one compiles
 completely fine, with no errors, using g++-7.5.0 on (Sorbet) Leopard. To
 save anyone else from needing to use git checkout and set it up, I'll
 attach a .zip archive to the problem report above that has the overlay, so
 all that's needed is to put the extracted folder somewhere and enter it
 into sources.conf (ahead of the main repository).

 I was able to get versions after that, including the most recent one
 (3.4.1 as of the time of this writing), to compile by adding " configure
 .cxxflags-append -fpermissive " underneath the two configure.args-append
 statements. This tells GCC to ignore the casting issues - probably not an
 advisable solution, but given that it appears as though it's only casting
 from final and it would fail on a modern compiler if it was incorrectly
 altered, there shouldn't be any code that actually affects it. And for
 what it's worth, I've been using it for the entire day and have yet to
 notice any issues or problems from it, though I'll update this comment
 here if I run into any. Hopefully, if I brush up on my C++, I can figure
 out why exactly this issue is occurring at some point and figure out a
 proper workaround, but for now, this seems to work.

 Thank you so much kencu for your guidance! You were extremely helpful, and
 it's great being able to use my full config and all its creature comforts
 on OS X.

-- 
Ticket URL: <https://trac.macports.org/ticket/65270#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS