[MacPorts] #65354: iTerm2 @3.4.15_3: SafeAreaInsets are still breaking builds on older systems

[MacPorts]

#65354: iTerm2 @3.4.15_3: SafeAreaInsets are still breaking builds on older systems
----------------------+--------------------
  Reporter:  Gandoon  |      Owner:  (none)
      Type:  defect   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.7.2
Resolution:           |   Keywords:
      Port:  iTerm2   |
----------------------+--------------------
Description changed by Gandoon:

Old description:

> The other day a new revision (3) of iTerm2 was released and it still
> gives some of us users of older systems problems due to `SafeAreaInsets`,
> which seems to be related to the notch on newer Macs.
>
> As the iTerm2 project development seems to have left the 3.4.15-era it
> may be possible that a submission to George Nachman would not necessarily
> be expediently addressed for source builds, I submit here a workaround
> source code- and Portfile patch that removes any use of `SafeAreaInsets`
> which were identified in now closed [ticket:63824]. This solves the build
> problems for at least MacOS 10.15, but will likely solve similar problems
> on 10.14 as well.
>
> There have been indications (see the closed ticket above) that also MacOS
> 11 may have this issue, so maybe the initial tests for `${os.major}` in
> the Portfile should be set to `> 20` instead of `${os.major} > 19`, but I
> do not have a MacOS 11 machine to test this on, so I played safe and put
> what I can test there. If someone wants to test on a MacOS 11 system and
> incorporate these fixes, feel free to just test that, it may work if you
> have issues building.

New description:

 The other day a new revision (3) of iTerm2 was released and it still gives
 some of us users of older systems problems due to `SafeAreaInsets`, which
 seems to be related to the notch on newer Macs.

 As the iTerm2 project development seems to have left the 3.4-era and moved
 on to working on v3.5, it may be possible that a submission to George
 Nachman would not necessarily be expediently addressed for source builds,
 I submit here a workaround source code- and Portfile patch that removes
 any use of `SafeAreaInsets` which were identified in now closed
 [ticket:63824]. This solves the build problems for at least MacOS 10.15,
 but will likely solve similar problems on 10.14 as well.

 There have been indications (see the closed ticket above) that also MacOS
 11 may have this issue, so maybe the initial tests for `${os.major}` in
 the Portfile should be set to `> 20` instead of `${os.major} > 19`, but I
 do not have a MacOS 11 machine to test this on, so I played safe and put
 what I can test there. If someone wants to test on a MacOS 11 system and
 incorporate these fixes, feel free to just test that, it may work if you
 have issues building.

--

-- 
Ticket URL: <https://trac.macports.org/ticket/65354#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS