[MacPorts] #65354: iTerm2 @3.4.15_3: SafeAreaInsets are still breaking builds on older systems

MacPorts noreply at macports.org
Sat Jun 18 15:00:41 UTC 2022


#65354: iTerm2 @3.4.15_3: SafeAreaInsets are still breaking builds on older systems
----------------------+----------------------
  Reporter:  Gandoon  |      Owner:  markemer
      Type:  defect   |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.7.2
Resolution:           |   Keywords:
      Port:  iTerm2   |
----------------------+----------------------

Comment (by Gandoon):

 A quick note. It may be better to somehow check for the presence of the
 symbols, but as far as I know, the only notched MacBook Pros out there
 ''with'' the notch are the 2021 models onwards. They all shipped with
 MacOS 12 from the start, so it is probably safe to comment out the
 portions on MacOS 11 versions as well. It would be unlikely to find a
 machine that has the notch running a MacOS 11 or earlier system outside
 perhaps Apple's own development circles. Hence, I doubt the code that gets
 commented out does anything useful on earlier machines anyway. So the
 presented source patch is probably safe to use in most cases, provided
 that it is not applied to any system running MacOS 12.

 Despite not having any proof for the statement, I have a strong feeling
 that the `safeAreaInsets` symbol actually only exists in MacOS 12.

-- 
Ticket URL: <https://trac.macports.org/ticket/65354#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list