[MacPorts] #65354: iTerm2 @3.4.15_3: SafeAreaInsets are still breaking builds on older systems

[MacPorts]

#65354: iTerm2 @3.4.15_3: SafeAreaInsets are still breaking builds on older systems
----------------------+----------------------
  Reporter:  Gandoon  |      Owner:  markemer
      Type:  defect   |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.7.2
Resolution:           |   Keywords:
      Port:  iTerm2   |
----------------------+----------------------

Comment (by kencu):

 Replying to [comment:6 Gandoon]:
 > Replying to [comment:5 kencu]:
 > > Replying to [comment:3 Gandoon]:
 > > > Despite not having any proof for the statement, I have a strong
 feeling that the `safeAreaInsets` symbol actually only exists in MacOS 12.
 > >
 > > The code you are commenting out says exactly that.
 >
 > Yes, I know. But the thing is that the compile system complains about
 the symbols being absent and refuses to build. The removal of the checks
 altogether fixes this on MacOS 10.15, and most likely on MacOS 11 as well,
 if the symbols are not present there either.


 I can't tell if you are agreeing with me or disagreeing with me :>

 The code you are commenting out only exists in newer SDKs. So old SDKs
 don't have it, so the build fails.

 The fix is to use the availability macros to block the code out on old
 SDKs

 here's an example of how to do it:

 https://github.com/macports/macports-ports/blob/master/aqua/qt5/files
 /patch-qt515-highsierra1.diff

-- 
Ticket URL: <https://trac.macports.org/ticket/65354#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS