[MacPorts] #65354: iTerm2 @3.4.15_3: SafeAreaInsets are still breaking builds on older systems
MacPorts
noreply at macports.org
Sun Jun 19 15:46:47 UTC 2022
#65354: iTerm2 @3.4.15_3: SafeAreaInsets are still breaking builds on older systems
----------------------+----------------------
Reporter: Gandoon | Owner: markemer
Type: defect | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version: 2.7.2
Resolution: | Keywords:
Port: iTerm2 |
----------------------+----------------------
Comment (by Gandoon):
Replying to [comment:8 kencu]:
>
> I can't tell if you are agreeing with me or disagreeing with me :>
>
No, no… I don't disagree with you. I am just not very well versed in the
usage of the availability macros you mention. I have mainly been active
here, submitting tickets, fairly recently as things have started to break
much more often for me. Possibly because I am still using a legacy OS. I
just shared what solutions I applied to solve the problem for me. The
solution is in no way, shape, or form made out to be an ideal solution,
but it works. I personally consider it a workaround.
>
> The code you are commenting out calls features that only exist in newer
SDKs. So old SDKs don't have it, so the build fails.
>
Indeed, that was the point of getting rid of it :)
> The fix is to use the availability macros to block the code out on old
SDKs
>
> here's an example of how to do it:
>
> https://github.com/macports/macports-ports/blob/master/aqua/qt5/files
/patch-qt515-highsierra1.diff
As for the availability macros, thank you for the example. I will have a
look at your suggested reading for the next time something like this comes
around. It would probably be good to learn how to do this.
(And if I have the time later today or tomorrow I may revisit this and see
if I can figure out how to do this for iTerm2. Unless someone else beat me
to it.)
--
Ticket URL: <https://trac.macports.org/ticket/65354#comment:10>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list