[MacPorts] #65270: Fish 3.4.1 fails to compile on Leopard PPC

[MacPorts]

#65270: Fish 3.4.1 fails to compile on Leopard PPC
-----------------------+--------------------
  Reporter:  acjones8  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:  2.7.2
Resolution:            |   Keywords:
      Port:  fish      |
-----------------------+--------------------

Comment (by acjones8):

 Unfortunately I don't know enough to fix it properly upstream myself, but
 I looked into making a proper patch, and my solution so far is to add a
 specific fix for darwin 9, which covers Leopard. This should eliminate the
 possibility of interference with any modern versions of OS X. It's super
 simple, just:

 {{{
 platform darwin 9 {
      # Fixes build issue on (Sorbet) Leopard
      # See: https://trac.macports.org/ticket/65270
      configure.cxxflags-append -fpermissive
 }
 }}}

 This works perfectly in my overlay, and I haven't observed any further
 issues since last week either. This is my first time working with MacPorts
 though, so if there's a better way of doing this or if I'm
 misunderstanding how `platform` works, I would definitely appreciate any
 suggestions on how to improve it. But if this looks good, I'll submit it
 to GitHub in a few days.

 However, @evanmiller , you mentioned that 3.3.1 works fine? If so, that's
 very interesting, since I couldn't get anything past 3.1.2 to work without
 this modification. It would be very strange that Tiger would be more
 compatible than Leopard, so perhaps this is an issue to my specific
 setup... although I haven't done anything unusual or non-standard, at
 least as far as I'm aware. Did you also compile it with GCC 7.5.0?

-- 
Ticket URL: <https://trac.macports.org/ticket/65270#comment:9>
MacPorts <https://www.macports.org/>
Ports system for macOS