[MacPorts] #66165: qt5-qtwebengine @5.15.10_1 (aqua): Processing of port qt5-qtwebengine failed

MacPorts noreply at macports.org
Sun Nov 6 14:32:48 UTC 2022


#66165: qt5-qtwebengine @5.15.10_1 (aqua): Processing of port qt5-qtwebengine
failed
------------------------------+---------------------------------
  Reporter:  wurzelsand       |      Owner:  MarcusCalhoun-Lopez
      Type:  defect           |     Status:  assigned
  Priority:  Normal           |  Milestone:
 Component:  ports            |    Version:  2.8.0
Resolution:                   |   Keywords:
      Port:  qt5-qtwebengine  |
------------------------------+---------------------------------

Comment (by chrstphrchvz):

 Likely not an ideal approach (and not something to propose to Qt without
 platform guards), but the only suggestion I currently have would be to try
 using a temporary `CGRect`:

 {{{
 ---
 a/src/3rdparty/chromium/third_party/blink/renderer/core/editing/finder/text_finder.cc
 +++
 b/src/3rdparty/chromium/third_party/blink/renderer/core/editing/finder/text_finder.cc
 @@ -629,7 +629,8 @@ gfx::RectF TextFinder::ActiveFindMatchRect() {
    if (!current_active_match_frame_ || !active_match_)
      return gfx::RectF();

 -  return
 gfx::RectF(FindInPageRectFromRange(EphemeralRange(ActiveMatch())));
 +  CGRect r = FindInPageRectFromRange(EphemeralRange(ActiveMatch()));
 +  return gfx::RectF(r);
  }

  Vector<gfx::RectF> TextFinder::FindMatchRects() {
 @@ -639,7 +640,8 @@
    match_rects.ReserveCapacity(match_rects.size() +
 find_matches_cache_.size());
    for (const FindMatch& match : find_matches_cache_) {
      DCHECK(!match.rect_.IsEmpty());
 -    match_rects.push_back(match.rect_);
 +    CGRect r = match.rect_;
 +    match_rects.push_back(r);
    }

    return match_rects;
 }}}

 PS I would appreciate if a volunteer could try building the 5.15.11
 update: [https://github.com/macports/macports-ports/pull/16311]

-- 
Ticket URL: <https://trac.macports.org/ticket/66165#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list