[MacPorts] #62339: MacVim wants to update through its built-in update mechanism

[MacPorts]

#62339: MacVim wants to update through its built-in update mechanism
-----------------------+----------------------
  Reporter:  szhorvat  |      Owner:  raimue
      Type:  defect    |     Status:  assigned
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:  2.6.4
Resolution:            |   Keywords:
      Port:  MacVim    |
-----------------------+----------------------

Comment (by raimue):

 Analyzing the history, I think the problem was introduced with
 [https://github.com/macports/macports-
 ports/commit/6418dc0d7fa5fa66993a2959a3704cd0196c4b38#diff-
 75d77e0653e84265e1c3b3dd07238d7c8f184244c0c5bac430851a696edf4820
 6418dc0d7fa5fa66993a2959a3704cd0196c4b38] as since then Sparkle.framework
 is no longer removed from the Xcode project.

 Upstream also has a [https://github.com/macvim-
 dev/macvim/blob/09d44aa8c51661f86f3875536fdf5520265b30ed/src/configure.ac#L239
 `--disable-sparkle` configure argument] that we use and it is supposed to
 set the `XCODEFLAGS` to disable Sparkle.

 However, the Portfile sets its own values for `XCODEFLAGS` and I would
 assume that the
 `GCC_PREPROCESSOR_DEFINITIONS='$GCC_PREPROCESSOR_DEFINITIONS
 DISABLE_SPARKLE=1'` is lost due to this.

 One possible solution could be to include this
 `GCC_PREPROCESSOR_DEFINITIONS` in our `XCODEFLAGS` in the Portfile.

-- 
Ticket URL: <https://trac.macports.org/ticket/62339#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS