[MacPorts] #67259: libocca fails to build with Clang on < 10.12: clock_get_time, mach_port_deallocate

[MacPorts]

#67259: libocca fails to build with Clang on < 10.12: clock_get_time,
mach_port_deallocate
---------------------------+--------------------------
  Reporter:  barracuda156  |      Owner:  barracuda156
      Type:  defect        |     Status:  assigned
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:  2.8.1
Resolution:                |   Keywords:
      Port:  libocca       |
---------------------------+--------------------------

Comment (by barracuda156):

 Replying to [comment:2 ryandesign]:
 > Don't really know why this code is checking for `__clang__` at all in
 either of the two places. All we care about is whether the OS has
 `clock_gettime_nsec_np`, which was introduced in macOS 10.12 along with
 `clock_gettime` (although legacysupport doesn't have
 `clock_gettime_nsec_np`; see #61691).

 Me neither, but I assumed there was some sense behind that. The issue was,
 I guess, that I should have amended the define in both places identically,
 and since that was not done, needed headers for `clock_get_time` and
 `mach_port_deallocate` did not get included on systems without
 CLOCK_UPTIME_RAW in combination with Clang. Since neither Macports CI nor
 my local testing machine fit this, that went unnoticed.

 I will amend the patch: indeed, why check for Clang there at all.

-- 
Ticket URL: <https://trac.macports.org/ticket/67259#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS