[MacPorts] #64175: fnc is not using the right compiler or arch flags

[MacPorts]

#64175: fnc is not using the right compiler or arch flags
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  mcjsk
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.7.1
Resolution:              |   Keywords:
      Port:  fnc         |
-------------------------+----------------------

Comment (by ryandesign):

 Replying to [comment:2 mcjsk]:
 > Replying to [comment:1 ryandesign]:
 > > I also see a `-I/usr/include/ncursesw` in there which is wrong since
 the port declares a dependency on the ncurses port so clearly we're
 wanting to use MacPorts ncurses, not any that might be provided by the OS.
 MacPorts cppflags come preset to `-I${prefix}/include` so by using those
 the right flag will be there. You may still need to take additional
 measures to remove the incorrect flag, depending on how it's getting into
 the build. (Read the Makefile to find out.)
 >
 > Thanks, ryandesign at . I'll tend to this.

 [changeset:d657b78c7618fb822ebfce6ee23e93e745bf62ef/macports-ports The
 makefile portgroup was added to the port] which takes care of using the
 right compiler and flags. But `-I/usr/include/ncursesw` is still present
 in the most recent build log and should be removed. I see it's simply
 hardcoded into `FNC_CFLAGS` in the fnc.bld.mk file so a patch should be
 added to remove that part.

 > Rather than depend on MacPorts ncurses, can we use the macOS base
 install instead? Originally, we didn't have the `port:ncurses` included in
 the `depends_lib`.

 We usually don't want to do that, as explained in wiki:FAQ#ownlibs.

-- 
Ticket URL: <https://trac.macports.org/ticket/64175#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS