[MacPorts] #67173: ffmpeg-upstream @5.1.2_4+gpl2+gpl3: broken build

[MacPorts]

#67173: ffmpeg-upstream @5.1.2_4+gpl2+gpl3: broken build
------------------------------+----------------------
  Reporter:  townba           |      Owner:  mascguy
      Type:  defect           |     Status:  assigned
  Priority:  Normal           |  Milestone:
 Component:  ports            |    Version:  2.8.1
Resolution:                   |   Keywords:
      Port:  ffmpeg-upstream  |
------------------------------+----------------------

Comment (by ryandesign):

 Comparing with our [https://build.macports.org/builders/ports-
 13_arm64-builder/builds/17470/steps/install-port/logs/stdio most recent
 log of building ffmpeg-upstream on macOS 13 on arm64], I don't see any
 invocations in clang during the destroot phase, which is how it should be.

 So, there are at least two bugs:

 1. something is causing re-linking of some libraries to happen in the
 destroot phase on your system
 2. when linking happens in the destroot phase, `$(DESTDIR)` is erroneously
 included in the install name

 Probably neither of these are specific to MacPorts and they should be
 reported to the developers of ffmpeg.

 I note that your 5.1.2 log says:

 {{{
 External libraries:
 appkit                  libmodplug              libvorbis
 avfoundation            libmp3lame              libvpx
 bzlib                   libopenjpeg             libx264
 coreimage               libopus                 libx265
 gnutls                  librav1e                libxvid
 iconv                   librsvg                 libzimg
 libaom                  libsmbclient            libzvbi
 libaribb24              libsmbclient            lzma
 libass                  libsoxr                 metal
 libbluray               libspeex                sdl2
 libfontconfig           libsvtav1               zlib
 libfreetype             libtheora
 libfribidi              libvidstab
 }}}

 While our 6.0 buildbot log says:

 {{{
 External libraries:
 appkit                  libfribidi              libvidstab
 avfoundation            libmodplug              libvorbis
 bzlib                   libmp3lame              libvpx
 coreimage               libopenjpeg             libx264
 gnutls                  libopus                 libx265
 iconv                   librav1e                libxvid
 libaom                  librsvg                 libzimg
 libass                  libsoxr                 libzvbi
 libbluray               libspeex                lzma
 libfontconfig           libsvtav1               sdl2
 libfreetype             libtheora               zlib
 }}}

 The relevant difference may be that yours has "metal" while ours does not
 (although it's difficult to know for sure when comparing different
 versions)—maybe attach your most recent log so we can do a better
 comparison.

-- 
Ticket URL: <https://trac.macports.org/ticket/67173#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS