[MacPorts] #67991: apcupsd @ 3.14.14_2: Should not autostart

[MacPorts]

#67991: apcupsd @ 3.14.14_2: Should not autostart
------------------------+-------------------------
 Reporter:  ryandesign  |      Owner:  stephenreay
     Type:  defect      |     Status:  assigned
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:  2.8.1
 Keywords:              |       Port:  apcupsd
------------------------+-------------------------
 I logged in to the buildbot workers today and was surprised to see a new
 icon at the right of the menubar that I didn't recognize. It was from
 apcupsd, whose portfile uses `startupitem.autostart yes`, which causes the
 program to launch when the port is activated.

 Users don't expect installing a port to run software. And the notes of the
 port's usb variant say an additional command must be run by the user
 before the software will be fully functional, so the user will probably
 want to run that command and then start the software, not the other way
 around.

 Additionally, on some buildbot workers, activation failed at the point
 where it tried to open the program, e.g.:

 https://build.macports.org/builders/ports-10.12_x86_64-builder/builds/241290/steps
 /install-port/logs/stdio

 {{{
 DEBUG: Executing proc-post-org.macports.activate-activate-0
 DEBUG: system: open /Applications/MacPorts/apcagent.app
 LSOpenURLsWithRole() failed with error -10810 for the file
 /Applications/MacPorts/apcagent.app.
 Command failed: open /Applications/MacPorts/apcagent.app
 Exit code: 1
 Error: Failed to activate apcupsd: command execution failed
 }}}

 Despite this error and the consequent activation failure, the program did
 open, which is confusing.

 Please remove `startupitem.autostart yes`. Since this changes installed
 files, the `revision` must be increased as well.

-- 
Ticket URL: <https://trac.macports.org/ticket/67991>
MacPorts <https://www.macports.org/>
Ports system for macOS