[MacPorts] #68871: btop broken on Catalina and below

[MacPorts]

#68871: btop broken on Catalina and below
-------------------------------------------------+-------------------------
 Reporter:  barracuda156                         |      Owner:  samasaur1
     Type:  defect                               |     Status:  assigned
 Priority:  Normal                               |  Milestone:
Component:  ports                                |    Version:  2.8.1
 Keywords:  catalina, mojave, highsierra,        |       Port:  btop
  sierra, elcapitan, yosemite, mavericks,        |
  mountainlion, lion, snowleopard, leopard,      |
  tiger                                          |
-------------------------------------------------+-------------------------
 From Catalina to Sierra it fails at linking:

 {{{
 Linking and optimizing binary...
 undef: __ZNSt3__120__libcpp_atomic_waitEPVKvx
 undef: __ZNSt3__123__libcpp_atomic_monitorEPVKv
 undef: __ZNSt3__123__cxx_atomic_notify_oneEPVKv
 Undefined symbols for architecture x86_64:
   "std::__1::__libcpp_atomic_wait(void const volatile*, long long)",
 referenced from:
       Runner::_runner(void*) in lto.o
   "std::__1::__libcpp_atomic_monitor(void const volatile*)", referenced
 from:
       Runner::_runner(void*) in lto.o
   "std::__1::__cxx_atomic_notify_one(void const volatile*)", referenced
 from:
       Runner::run(std::__1::basic_string<char,
 std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool,
 bool) in lto.o
       Runner::stop() in lto.o
 ld: symbol(s) not found for architecture x86_64
 clang: error: linker command failed with exit code 1 (use -v to see
 invocation)
 make: *** [btop] Error 1
 }}}

 https://build.macports.org/builders/ports-10.15_x86_64-builder/builds/164615/steps
 /install-port/logs/stdio

 {{{
 Linking and optimizing binary...
 undef: __ZNKSt3__14__fs10filesystem4path16__root_directoryEv
 undef: __ZNSt3__120__libcpp_atomic_waitEPVKvx
 undef:
 __ZNSt3__14__fs10filesystem11__file_sizeERKNS1_4pathEPNS_10error_codeE
 undef:
 __ZNSt3__14__fs10filesystem8__renameERKNS1_4pathES4_PNS_10error_codeE
 undef: __ZNKSt3__14__fs10filesystem4path6__stemEv
 undef:
 __ZNSt3__14__fs10filesystem18directory_iterator11__incrementEPNS_10error_codeE
 undef:
 __ZNSt3__14__fs10filesystem18__create_directoryERKNS1_4pathEPNS_10error_codeE
 undef: __ZNKSt3__14__fs10filesystem18directory_iterator13__dereferenceEv
 undef:
 __ZNSt3__14__fs10filesystem20__create_directoriesERKNS1_4pathEPNS_10error_codeE
 undef: __ZNSt3__123__libcpp_atomic_monitorEPVKv
 undef:
 __ZNSt3__14__fs10filesystem18directory_iteratorC1ERKNS1_4pathEPNS_10error_codeENS1_17directory_optionsE
 undef:
 __ZNSt3__14__fs10filesystem11__canonicalERKNS1_4pathEPNS_10error_codeE
 undef: __ZNKSt3__14__fs10filesystem4path11__extensionEv
 undef: __ZNSt3__14__fs10filesystem8__statusERKNS1_4pathEPNS_10error_codeE
 undef: __ZNSt3__14__fs10filesystem8__removeERKNS1_4pathEPNS_10error_codeE
 undef: __ZNKSt3__14__fs10filesystem4path10__filenameEv
 undef:
 __ZNKSt3__14__fs10filesystem4path9__compareENS_17basic_string_viewIcNS_11char_traitsIcEEEE
 undef: __ZNSt3__123__cxx_atomic_notify_oneEPVKv
 Undefined symbols for architecture x86_64:
   "std::__1::__fs::filesystem::path::__root_directory() const", referenced
 from:
       __ZNSt3__14__fs10filesystemdvB7v160006ERKNS1_4pathES4_ in lto.o
   "std::__1::__libcpp_atomic_wait(void const volatile*, long long)",
 referenced from:
       Runner::_runner(void*) in lto.o
 "std::__1::__fs::filesystem::__file_size(std::__1::__fs::filesystem::path
 const&, std::__1::error_code*)", referenced from:
       Logger::log_write(unsigned long, std::__1::basic_string<char,
 std::__1::char_traits<char>, std::__1::allocator<char> > const&) in lto.o
   "std::__1::__fs::filesystem::__rename(std::__1::__fs::filesystem::path
 const&, std::__1::__fs::filesystem::path const&, std::__1::error_code*)",
 referenced from:
       Logger::log_write(unsigned long, std::__1::basic_string<char,
 std::__1::char_traits<char>, std::__1::allocator<char> > const&) in lto.o
   "std::__1::__fs::filesystem::path::__stem() const", referenced from:
       Theme::setTheme() in lto.o
       Menu::optionsMenu(std::__1::basic_string<char,
 std::__1::char_traits<char>, std::__1::allocator<char> > const&) in lto.o
 "std::__1::__fs::filesystem::directory_iterator::__increment(std::__1::error_code*)",
 referenced from:
       Theme::updateThemes() in lto.o
 "std::__1::__fs::filesystem::__create_directory(std::__1::__fs::filesystem::path
 const&, std::__1::error_code*)", referenced from:
       _main in lto.o
   "std::__1::__fs::filesystem::directory_iterator::__dereference() const",
 referenced from:
       Theme::updateThemes() in lto.o
 "std::__1::__fs::filesystem::__create_directories(std::__1::__fs::filesystem::path
 const&, std::__1::error_code*)", referenced from:
       _main in lto.o
   "std::__1::__libcpp_atomic_monitor(void const volatile*)", referenced
 from:
       Runner::_runner(void*) in lto.o
 "std::__1::__fs::filesystem::directory_iterator::directory_iterator(std::__1::__fs::filesystem::path
 const&, std::__1::error_code*,
 std::__1::__fs::filesystem::directory_options)", referenced from:
       Theme::updateThemes() in lto.o
 "std::__1::__fs::filesystem::__canonical(std::__1::__fs::filesystem::path
 const&, std::__1::error_code*)", referenced from:
       _main in lto.o
       Mem::collect(bool) in lto.o
   "std::__1::__fs::filesystem::path::__extension() const", referenced
 from:
       Theme::updateThemes() in lto.o
   "std::__1::__fs::filesystem::__status(std::__1::__fs::filesystem::path
 const&, std::__1::error_code*)", referenced from:
       _main in lto.o
       Config::load(std::__1::__fs::filesystem::path const&,
 std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>,
 std::__1::allocator<char> >,
 std::__1::allocator<std::__1::basic_string<char,
 std::__1::char_traits<char>, std::__1::allocator<char> > > >&) in lto.o
       Theme::setTheme() in lto.o
       Logger::log_write(unsigned long, std::__1::basic_string<char,
 std::__1::char_traits<char>, std::__1::allocator<char> > const&) in lto.o
       Shared::init() in lto.o
       Mem::collect(bool) in lto.o
   "std::__1::__fs::filesystem::__remove(std::__1::__fs::filesystem::path
 const&, std::__1::error_code*)", referenced from:
       Logger::log_write(unsigned long, std::__1::basic_string<char,
 std::__1::char_traits<char>, std::__1::allocator<char> > const&) in lto.o
   "std::__1::__fs::filesystem::path::__filename() const", referenced from:
       _main in lto.o
       Theme::setTheme() in lto.o
       Mem::collect(bool) in lto.o
       __ZNSt3__14__fs10filesystemdvB7v160006ERKNS1_4pathES4_ in lto.o
 "std::__1::__fs::filesystem::path::__compare(std::__1::basic_string_view<char,
 std::__1::char_traits<char> >) const", referenced from:
       Theme::updateThemes() in lto.o
       Theme::setTheme() in lto.o
   "std::__1::__cxx_atomic_notify_one(void const volatile*)", referenced
 from:
       Runner::run(std::__1::basic_string<char,
 std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool,
 bool) in lto.o
       Runner::stop() in lto.o
 ld: symbol(s) not found for architecture x86_64
 clang: error: linker command failed with exit code 1 (use -v to see
 invocation)
 make: *** [btop] Error 1
 }}}

 https://build.macports.org/builders/ports-10.12_x86_64-builder/builds/253081/steps
 /install-port/logs/stdio

 On El Capitan and below it uses wrong headers:
 {{{
 src/osx/sensors.cpp:22:10: fatal error:
 'IOKit/hidsystem/IOHIDEventSystemClient.h' file not found
 #include <IOKit/hidsystem/IOHIDEventSystemClient.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 src/osx/sensors.cpp:22:10: note: did not find header
 'hidsystem/IOHIDEventSystemClient.h' in framework 'IOKit' (loaded from
 '/System/Library/Frameworks')
 1 warning and 1 error generated.
 make: *** [obj/osx/sensors.o] Error 1
 }}}

 I will test a build with gcc on PowerPC tomorrow, but I think the same
 SDK-related error will pop up.

-- 
Ticket URL: <https://trac.macports.org/ticket/68871>
MacPorts <https://www.macports.org/>
Ports system for macOS